Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support OpenTelemetry #8810

Merged
merged 232 commits into from
Feb 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
232 commits
Select commit Hold shift + click to select a range
1a26a6c
add @opentelemetry related modules
skomma Apr 3, 2024
ad930c2
run "yarn add @vercel/otel"
skomma Apr 3, 2024
96a9842
add instrumentation hook(currently not workking)
skomma Apr 3, 2024
5cf2a94
add otel preparation code in index.js
skomma Apr 4, 2024
74293e3
remove unnecessary @vercel/otel module
skomma Apr 4, 2024
1c69166
run "yarn add @opentelemetry/exporter-trace-otlp-grpc"
skomma Apr 4, 2024
b834925
add auto-instrumentation / otlp-trace-exporter with grpc
skomma Apr 4, 2024
37fbd25
add "@opentelemetry/exporter-metrics-otlp-grpc" package
skomma Apr 8, 2024
73070d3
add opentelemetry network in docker-compose.yml
skomma Apr 8, 2024
3851ab5
remove unnecessary lines
skomma Apr 8, 2024
07fbd57
add version, instance id
skomma Apr 8, 2024
cb318b7
divide instrumentation code
skomma Apr 10, 2024
a757bc9
comment out opentelemetry-collector docker networks
skomma Apr 10, 2024
abe6534
update packages
skomma Apr 11, 2024
1f1b92a
add comment
skomma Apr 11, 2024
2653624
fix comments
skomma Apr 11, 2024
d764012
Merge pull request #8667 from weseek/feat/143808-can-send-traces-with…
yuki-takei Apr 11, 2024
35bdb37
add env vars
skomma Apr 12, 2024
50cb8f9
add instance ID env var
skomma Apr 12, 2024
dcec166
load from env vars
skomma Apr 12, 2024
93a62e0
Merge remote-tracking branch 'origin/master' into feat/144409-144410-…
skomma Apr 15, 2024
d6f8f5e
adjust env var names
skomma Apr 15, 2024
df32813
stop passing crowi instance / use direct import for configManager
skomma Apr 15, 2024
886fb9d
respect OTEL_* env vars as far as possible
skomma Apr 15, 2024
7df8b4a
change overwriteSdkDisabled()
skomma Apr 15, 2024
0aa3def
chore: remove unnecessary import
skomma Apr 15, 2024
9effb02
Merge remote-tracking branch 'origin/master' into feat/opentelemetry
skomma Apr 15, 2024
8bb9acb
Merge branch 'feat/opentelemetry' into feat/144409-144410-can-specify…
skomma Apr 15, 2024
87ca999
Merge pull request #8714 from weseek/feat/144409-144410-can-specify-o…
yuki-takei Apr 16, 2024
dc2575a
Merge remote-tracking branch 'origin/master' into feat/opentelemetry
skomma Apr 17, 2024
7e0b469
Merge remote-tracking branch 'origin/master' into feat/opentelemetry
skomma Apr 23, 2024
6841a17
Merge branch 'master' into feat/opentelemetry
miya May 12, 2024
f940367
Merge branch 'master' into feat/opentelemetry
miya May 14, 2024
a6a3b3e
Merge branch 'master' into feat/opentelemetry
yuki-takei May 15, 2024
b4cbb22
modify key
yuki-takei May 15, 2024
5031030
Merge commit 'ffcb885af03134f55dd22a687eab4b7c87d5516f' (7.0.x) into …
yuki-takei Nov 13, 2024
75e03f6
Merge branch 'master' into feat/opentelemetry
yuki-takei Nov 13, 2024
673a5b6
update pnpm-lock.yaml
yuki-takei Nov 13, 2024
f869361
Merge branch 'feat/opentelemetry' into imprv/switch-otel-enabled
yuki-takei Nov 14, 2024
4bf8641
upgrade @opentelemetry/* packages
yuki-takei Nov 14, 2024
cf693bb
clean code
yuki-takei Nov 14, 2024
64b927a
Merge branch 'feat/opentelemetry' into imprv/switch-otel-enabled
yuki-takei Nov 14, 2024
d7b878b
add global logger for opentelemetry
yuki-takei Nov 14, 2024
b76f5e9
relocate opentelemetry modules
yuki-takei Nov 14, 2024
648013f
refactor
yuki-takei Nov 14, 2024
fff6ca1
devide logger
yuki-takei Nov 14, 2024
851c6a0
fix consts
yuki-takei Nov 14, 2024
beb09d0
set GROWI version
yuki-takei Nov 14, 2024
d82add4
refactor and output information
yuki-takei Nov 14, 2024
e75d9ef
disable opentelemetry in dev
yuki-takei Nov 14, 2024
2c030d0
Merge branch 'master' into feat/opentelemetry
yuki-takei Nov 14, 2024
4aac9e2
Merge branch 'feat/opentelemetry' into imprv/switch-otel-enabled
yuki-takei Nov 14, 2024
da71773
BugFix
yuki-takei Nov 14, 2024
cc7d7fe
BugFix
yuki-takei Nov 14, 2024
ab9ed28
devide modules and import dynamically
yuki-takei Nov 15, 2024
a2cbd63
Merge pull request #8811 from weseek/imprv/switch-otel-enabled
yuki-takei Nov 15, 2024
9a65036
Merge remote-tracking branch 'origin/master' into feat/opentelemetry
yuki-takei Nov 15, 2024
5f8ac57
Merge branch 'master' into feat/opentelemetry
yuki-takei Nov 18, 2024
b8a499c
WIP: generate codes by claude
yuki-takei Nov 18, 2024
02f4663
Merge branch 'master' into feat/opentelemetry
yuki-takei Nov 19, 2024
eac938c
Merge branch 'feat/opentelemetry' into support/new-config-manager
yuki-takei Nov 19, 2024
ec5ae2a
add test
yuki-takei Nov 19, 2024
d614a8b
output MongoMemoryServer uri
yuki-takei Nov 19, 2024
7e05bb5
add integration tests for updating and removing configs
yuki-takei Nov 19, 2024
d10d492
implements S2sMessageHandlable
yuki-takei Nov 19, 2024
9471930
improve test
yuki-takei Nov 19, 2024
f7b05f4
migrate configuration values to config-definition.ts from config-load…
yuki-takei Nov 19, 2024
5862741
sort keys
yuki-takei Nov 19, 2024
b542cbe
sort CONFIG_DEFINITIONS
yuki-takei Nov 19, 2024
6125307
clean code
yuki-takei Nov 19, 2024
332c1a4
Merge branch 'master' into support/new-config-manager
yuki-takei Nov 22, 2024
34d7b29
remove ns from Config model
yuki-takei Nov 23, 2024
9fca1dc
relocate config-manager modules
yuki-takei Nov 23, 2024
834bd12
relocate old config-manager modules
yuki-takei Nov 23, 2024
7174837
update tests
yuki-takei Nov 23, 2024
7ecdabd
remove broken dev:migrate:create script
yuki-takei Nov 23, 2024
9ff9b7a
reorganize interfaces
yuki-takei Nov 23, 2024
193bf02
refactor ConfigManager
yuki-takei Nov 23, 2024
11c41fc
improve shouldUseEnvOnly
yuki-takei Nov 23, 2024
3774cf5
fix type
yuki-takei Nov 24, 2024
d0ac93d
impl getConfig overload
yuki-takei Nov 24, 2024
9930e4b
import configManager
yuki-takei Nov 24, 2024
2a235fa
improve parsing env var
yuki-takei Nov 24, 2024
b91cef9
implement getManagedEnvVars
yuki-takei Nov 24, 2024
3d5b477
refactor
yuki-takei Nov 24, 2024
0b76fbb
refactor getManagedEnvVars
yuki-takei Nov 24, 2024
bdbd51c
update comment for deprecated getConfig
yuki-takei Nov 25, 2024
5dbbafa
update [[...path]].page.tsx
yuki-takei Nov 25, 2024
862f4c1
Merge remote-tracking branch 'origin/master' into support/new-config-…
yuki-takei Nov 25, 2024
29978a7
add type annotations
yuki-takei Nov 25, 2024
b90f865
improve loading configs from DB
yuki-takei Nov 25, 2024
d599ea1
improve type references
yuki-takei Nov 25, 2024
b686941
fix customAttrWhitelist parsing
yuki-takei Nov 25, 2024
6a1ac48
improve getManagedEnvVars
yuki-takei Nov 25, 2024
a877248
fix importing types
yuki-takei Nov 26, 2024
84aa71a
refactor getConfig
yuki-takei Nov 26, 2024
a658d13
omit getEnvVarsForDisplay
yuki-takei Nov 26, 2024
1c6e7fd
replace method call
yuki-takei Nov 26, 2024
acb70e0
replace method call
yuki-takei Nov 26, 2024
cb41cf2
replace method call
yuki-takei Nov 26, 2024
0f6bf97
replace method call
yuki-takei Nov 26, 2024
b46a06c
replace method call
yuki-takei Nov 26, 2024
b6e359a
bugfix
yuki-takei Nov 26, 2024
5a20a5d
Merge branch 'master' into support/new-config-manager
yuki-takei Dec 2, 2024
a5e9c40
add db configs
yuki-takei Dec 2, 2024
ebd2dac
Merge branch 'master' into support/new-config-manager
yuki-takei Dec 10, 2024
c5e75e9
tidy up logger output
yuki-takei Dec 10, 2024
78778e9
update keys for useOnlyEnvVars
yuki-takei Dec 10, 2024
5f54db4
deprecate ns
yuki-takei Dec 10, 2024
f82529e
update code for detecting difference between old and new
yuki-takei Dec 10, 2024
c6a4163
set an empty string as a default for 'gcs:uploadNamespace'
yuki-takei Dec 10, 2024
a78fea9
update code for detecting difference between old and new
yuki-takei Dec 10, 2024
fb864fc
Merge branch 'master' into support/new-config-manager
yuki-takei Dec 10, 2024
27e1909
BugFix after update
yuki-takei Dec 10, 2024
6eb275a
impl checkDifference
yuki-takei Dec 10, 2024
168748b
fix: replace strict null checks with loose equality for consistency
yuki-takei Dec 10, 2024
8857434
add test
yuki-takei Dec 10, 2024
7a1aaef
Merge branch 'master' into feat/opentelemetry
yuki-takei Dec 10, 2024
bfee314
Merge branch 'feat/opentelemetry' into support/new-config-manager
yuki-takei Dec 10, 2024
d9043a2
fix test
yuki-takei Dec 10, 2024
1d53c2f
fix test
yuki-takei Dec 10, 2024
45bc319
add missing definition
yuki-takei Dec 11, 2024
b653c23
fix test
yuki-takei Dec 11, 2024
d9e40b3
fix test
yuki-takei Dec 11, 2024
d6a3382
add missed keys and definitions
yuki-takei Dec 13, 2024
7c19f7b
add missed keys and definitions
yuki-takei Dec 13, 2024
2941dce
make codes type safe
yuki-takei Dec 13, 2024
2114a68
add missed keys and definitions
yuki-takei Dec 13, 2024
a61b2f9
fix default value of serviceInstanceId
yuki-takei Dec 13, 2024
8552cc0
improve typings
yuki-takei Dec 13, 2024
6d41b67
fix typings
yuki-takei Dec 13, 2024
788d30a
fix typings
yuki-takei Dec 13, 2024
b137c05
improve typings
yuki-takei Dec 13, 2024
fef1ef4
fix typings
yuki-takei Dec 13, 2024
90b4280
improve typings
yuki-takei Dec 13, 2024
78bf5c7
add missed keys and definitions
yuki-takei Dec 13, 2024
671ba53
improve tpings
yuki-takei Dec 13, 2024
472fd5c
improve typings
yuki-takei Dec 13, 2024
fda0f03
improve getAssistantModelByType
yuki-takei Dec 13, 2024
0ed54b5
replace getConfig calls
yuki-takei Dec 13, 2024
a37da37
omit deprecated getConfig
yuki-takei Dec 13, 2024
47769c5
fix calling new getConfig
yuki-takei Dec 16, 2024
b876153
improve typings
yuki-takei Dec 16, 2024
3b304bd
refactor passport.spec.ts
yuki-takei Dec 16, 2024
9368d01
fix getConfigSpy
yuki-takei Dec 16, 2024
586a572
remove facebook implementation
yuki-takei Dec 16, 2024
426f1ce
improve typings
yuki-takei Dec 16, 2024
23039e3
fix test
yuki-takei Dec 17, 2024
6a3f5bc
improve typings
yuki-takei Dec 17, 2024
5d3e2e5
improve typings
yuki-takei Dec 17, 2024
b45a3f0
improve log
yuki-takei Dec 17, 2024
f8630b6
Merge remote-tracking branch 'origin/master' into support/new-config-…
yuki-takei Dec 18, 2024
a162982
remove env vars `FILE_UPLOAD_DISABLED` and `DISABLE_LINK_SHARING`
yuki-takei Dec 18, 2024
a8b7bb6
fix import line
yuki-takei Dec 18, 2024
8e14fe1
update initDB
yuki-takei Dec 18, 2024
e302f7e
Merge pull request #9473 from weseek/support/new-config-manager
yuki-takei Dec 18, 2024
01c609a
Merge remote-tracking branch 'origin/master' into feat/opentelemetry
yuki-takei Dec 18, 2024
dc1119f
Merge branch 'feat/opentelemetry' into support/new-config-manager
yuki-takei Dec 18, 2024
fcad7fb
Merge pull request #9500 from weseek/support/new-config-manager
yuki-takei Dec 18, 2024
0385394
get config from env
yuki-takei Dec 18, 2024
f783d45
get config value without initializing the legacy ConfigManager
yuki-takei Dec 18, 2024
26694cf
invoke startInstrumentation at first
yuki-takei Dec 18, 2024
1826583
improve importing ConfigSource consts
yuki-takei Dec 19, 2024
dc02ae6
Merge pull request #9507 from weseek/imprv/start-instrumentation-at-f…
mergify[bot] Dec 19, 2024
71550f1
WIP: refactor IGrowiInfo interface
yuki-takei Dec 19, 2024
93ab2f8
fix typings
yuki-takei Dec 23, 2024
d2a801d
improve typings
yuki-takei Dec 23, 2024
d4981bd
improve typings
yuki-takei Dec 23, 2024
9147398
convert questionnaire answers to legacy format and add tests for conv…
yuki-takei Dec 23, 2024
84fd05f
fix test
yuki-takei Dec 23, 2024
ee1cc49
Merge branch 'master' into feat/opentelemetry
yuki-takei Dec 27, 2024
f5c5d22
Merge branch 'feat/opentelemetry' into imprv/start-instrumentation-at…
yuki-takei Dec 27, 2024
79181c3
clean test code
yuki-takei Jan 7, 2025
e5442c2
avoid hard coding for id
yuki-takei Jan 7, 2025
4707657
relocate test
yuki-takei Jan 7, 2025
0b7127e
clean code
yuki-takei Jan 7, 2025
15b8541
rewrite with vitest
yuki-takei Jan 7, 2025
2dfc478
Merge remote-tracking branch 'origin/master' into imprv/start-instrum…
yuki-takei Jan 7, 2025
7e94099
Merge remote-tracking branch 'origin/master' into feat/opentelemetry
yuki-takei Jan 7, 2025
06a0f4e
Merge branch 'feat/opentelemetry' into imprv/start-instrumentation-at…
yuki-takei Jan 7, 2025
577c8b7
Merge pull request #9516 from weseek/imprv/start-instrumentation-at-f…
yuki-takei Jan 7, 2025
f0188e4
devide getGrowiInfo as a service
yuki-takei Jan 7, 2025
6c2cb13
refactor getGrowiInfo
yuki-takei Jan 7, 2025
a1a4107
Merge branch 'master' into feat/opentelemetry
yuki-takei Jan 8, 2025
2574536
Merge branch 'feat/opentelemetry' into imprv/generate-site-url-hashed…
yuki-takei Jan 8, 2025
4863fed
upgrade opentelemetry packages
yuki-takei Jan 8, 2025
027a3d4
implement initServiceInstanceId
yuki-takei Jan 8, 2025
8588af5
get GROWI version fron getGrowiVersion()
yuki-takei Jan 8, 2025
e8a04ae
fix lint errors
yuki-takei Jan 8, 2025
ed87f47
instanciate at first
yuki-takei Jan 9, 2025
cc21af7
add 'app:serviceInstanceId' key to config
yuki-takei Jan 9, 2025
496db0d
generate service instance id in migration script at first
yuki-takei Jan 10, 2025
be81410
update IGrowiInfo interface to include serviceInstanceId and osInfo; …
yuki-takei Jan 10, 2025
708c45a
add changeset file
yuki-takei Jan 10, 2025
a02046f
refactor
yuki-takei Jan 15, 2025
8b4cd95
remove uuidv4 updating for app:serviceInstanceId in InstallerService
yuki-takei Jan 15, 2025
8b0af79
initialize service instance id after DB is initialized
yuki-takei Jan 15, 2025
ff689e6
refactor getSiteUrl()
yuki-takei Jan 15, 2025
47c7c3a
replace appService.getSiteUrl with growiInfoService.getSiteUrl
yuki-takei Jan 15, 2025
96af015
Add OIDC configuration keys and definitions
yuki-takei Jan 15, 2025
b97a6b6
implement getConfigLegacy
yuki-takei Jan 15, 2025
7bdb963
Merge branch 'master' into feat/opentelemetry
yuki-takei Jan 17, 2025
68055e1
Merge branch 'feat/opentelemetry' into imprv/generate-site-url-hashed…
yuki-takei Jan 17, 2025
5a455de
make passport service type safe
yuki-takei Jan 17, 2025
b32ee54
make codes type-safe
yuki-takei Jan 17, 2025
7386b48
add configs for mail settings
yuki-takei Jan 21, 2025
50de380
improve typings
yuki-takei Jan 21, 2025
2077c03
improve typings
yuki-takei Jan 21, 2025
f09bceb
Merge branch 'master' into imprv/generate-site-url-hashed-isolatedly
yuki-takei Jan 22, 2025
5026eac
improve typings
yuki-takei Jan 22, 2025
6d1e2e2
Merge branch 'master' into feat/opentelemetry
yuki-takei Jan 22, 2025
42c8038
Merge branch 'feat/opentelemetry' into imprv/generate-site-url-hashed…
yuki-takei Jan 22, 2025
85637a8
fix test
yuki-takei Jan 22, 2025
d0bed9b
Merge pull request #9542 from weseek/imprv/generate-site-url-hashed-i…
yuki-takei Jan 22, 2025
ee21b4e
clean code
yuki-takei Jan 22, 2025
c8a87bb
add type Crowi
yuki-takei Jan 22, 2025
9207850
add Crowi type or type annotation
yuki-takei Jan 23, 2025
7d317dd
improve typings
yuki-takei Jan 23, 2025
34b6ced
fix lint errors
yuki-takei Jan 23, 2025
5cf6d9b
import configManager statically
yuki-takei Jan 23, 2025
584a876
Merge branch 'master' into imprv/types-for-crowi-and-config-manager
yuki-takei Jan 27, 2025
4b0769a
Merge branch 'master' into imprv/types-for-crowi-and-config-manager
yuki-takei Jan 27, 2025
56e4475
Merge pull request #9580 from weseek/imprv/types-for-crowi-and-config…
mergify[bot] Jan 27, 2025
66b3de6
Merge branch 'master' into feat/opentelemetry
yuki-takei Jan 27, 2025
433c9ae
Merge branch 'master' into feat/opentelemetry
yuki-takei Jan 29, 2025
119e33f
add network for opentelemetry-collector-dev-setup
yuki-takei Jan 30, 2025
c7f7649
update default settings for otel
yuki-takei Jan 30, 2025
8a80558
ignore .env for devcontainer
yuki-takei Jan 30, 2025
25b4512
add OpenTelemetry default configuration for dev
yuki-takei Jan 30, 2025
4d4b368
bump minor version
yuki-takei Jan 30, 2025
982c396
relocate migrate script
yuki-takei Jan 30, 2025
f002990
Merge branch 'master' into feat/opentelemetry
yuki-takei Feb 3, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clever-impalas-dress.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@growi/core': minor
---

Update GrowiInfo interface
1 change: 1 addition & 0 deletions .devcontainer/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.env
8 changes: 8 additions & 0 deletions .devcontainer/compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ services:
- ../../growi-docker-compose:/workspace/growi-docker-compose:delegated
- ../../share:/workspace/share:delegated
tty: true
networks:
- default
- opentelemetry-collector-dev-setup_default

mongo:
image: mongo:6.0
Expand Down Expand Up @@ -45,3 +48,8 @@ volumes:
pnpm-store:
node_modules:
buildcache_app:

networks:
default:
opentelemetry-collector-dev-setup_default:
external: ${OPENTELEMETRY_COLLECTOR_DEV_ENABLED:-false}
4 changes: 4 additions & 0 deletions apps/app/.env.development
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,7 @@ QUESTIONNAIRE_SERVER_ORIGIN="http://host.docker.internal:3003"
# AUDIT_LOG_ACTION_GROUP_SIZE=SMALL
# AUDIT_LOG_ADDITIONAL_ACTIONS=
# AUDIT_LOG_EXCLUDE_ACTIONS=

# OpenTelemetry Configuration
OPENTELEMETRY_ENABLED=false
OTEL_EXPORTER_OTLP_ENDPOINT=http://otel-collector:4317
4 changes: 4 additions & 0 deletions apps/app/.env.production
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,7 @@
##
FORMAT_NODE_LOG=false
MIGRATIONS_DIR=dist/migrations/

# OpenTelemetry Configuration
OTEL_TRACES_SAMPLER_ARG=0.1

12 changes: 10 additions & 2 deletions apps/app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@growi/app",
"version": "7.1.10-RC.0",
"version": "7.2.0-RC.0",
"license": "MIT",
"private": "true",
"scripts": {
Expand All @@ -21,7 +21,6 @@
"dev:pre:styles": "pnpm run pre:styles --mode dev",
"dev:migrate-mongo": "cross-env NODE_ENV=development pnpm run ts-node node_modules/migrate-mongo/bin/migrate-mongo",
"dev:migrate": "pnpm run dev:migrate:status > tmp/cache/migration-status.out && pnpm run dev:migrate:up",
"dev:migrate:create": "pnpm run dev:migrate-mongo create -f config/migrate-mongo-config.js",
"dev:migrate:status": "pnpm run dev:migrate-mongo status -f config/migrate-mongo-config.js",
"dev:migrate:up": "pnpm run dev:migrate-mongo up -f config/migrate-mongo-config.js",
"dev:migrate:down": "pnpm run dev:migrate-mongo down -f config/migrate-mongo-config.js",
Expand Down Expand Up @@ -84,6 +83,15 @@
"@growi/remark-lsx": "workspace:^",
"@growi/slack": "workspace:^",
"@keycloak/keycloak-admin-client": "^18.0.0",
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/auto-instrumentations-node": "^0.55.1",
"@opentelemetry/exporter-metrics-otlp-grpc": "^0.57.0",
"@opentelemetry/exporter-trace-otlp-grpc": "^0.57.0",
"@opentelemetry/resources": "^1.28.0",
"@opentelemetry/semantic-conventions": "^1.28.0",
"@opentelemetry/sdk-metrics": "^1.28.0",
"@opentelemetry/sdk-node": "^0.57.0",
"@opentelemetry/sdk-trace-node": "^1.28.0",
"@slack/web-api": "^6.2.4",
"@slack/webhook": "^6.0.0",
"JSONStream": "^1.3.5",
Expand Down
3 changes: 0 additions & 3 deletions apps/app/public/static/locales/en_US/admin.json
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,6 @@
"register_5": "Copy and paste your ClientID and Client Secret above",
"updated_google": "Succeeded to update Google OAuth setting"
},
"Facebook": {
"name": "Facebook OAuth"
},
"GitHub": {
"enable_github": "Enable GitHub OAuth",
"name": "GitHub OAuth",
Expand Down
3 changes: 0 additions & 3 deletions apps/app/public/static/locales/fr_FR/admin.json
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,6 @@
"register_5": "Copier l'ID client et Secret client ci-dessus",
"updated_google": "Paramètres mis à jour"
},
"Facebook": {
"name": "Facebook OAuth"
},
"GitHub": {
"enable_github": "Activer GitHub OAuth",
"name": "GitHub OAuth",
Expand Down
3 changes: 0 additions & 3 deletions apps/app/public/static/locales/ja_JP/admin.json
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,6 @@
"register_5": "上記フォームにクライアントIDとクライアントシークレットを入力",
"updated_google": "Google OAuth を更新しました"
},
"Facebook": {
"name": "Facebook OAuth"
},
"GitHub": {
"enable_github": "GitHub OAuth を有効にする",
"name": "GitHub OAuth",
Expand Down
3 changes: 0 additions & 3 deletions apps/app/public/static/locales/zh_CN/admin.json
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,6 @@
"register_5": "Copy and paste your ClientID and Client Secret above",
"updated_google": "Succeeded to update Google OAuth setting"
},
"Facebook": {
"name": "Facebook OAuth"
},
"GitHub": {
"enable_github": "Enable GitHub OAuth",
"name": "GitHub OAuth",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const CustomizeTitle: FC = () => {

const { data: customizeTitle } = useCustomizeTitle();

const [currentCustomizeTitle, setCrrentCustomizeTitle] = useState(customizeTitle);
const [currentCustomizeTitle, setCrrentCustomizeTitle] = useState(customizeTitle ?? '');

const onClickSubmit = async() => {
try {
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { TabContent, TabPane } from 'reactstrap';

import CustomNav from '../../CustomNavigation/CustomNav';

// import FacebookSecuritySetting from './FacebookSecuritySetting';
import GitHubSecuritySetting from './GitHubSecuritySetting';
import GoogleSecuritySetting from './GoogleSecuritySetting';
import LdapSecuritySetting from './LdapSecuritySetting';
Expand Down Expand Up @@ -53,10 +52,6 @@ const SecurityManagementContents = () => {
Icon: () => <span className="growi-custom-icons align-bottom">github</span>,
i18n: 'GitHub',
},
// passport_facebook: {
// Icon: () => <span className="growi-custom-icons align-bottom">facebook</span>,
// i18n: '(TBD) Facebook',
// },
};
}, []);

Expand Down Expand Up @@ -114,9 +109,6 @@ const SecurityManagementContents = () => {
<TabPane tabId="passport_github">
{activeComponents.has('passport_github') && <GitHubSecuritySetting />}
</TabPane>
{/* <TabPane tabId="passport_facebook">
{activeComponents.has('passport_facebook') && <FacebookSecuritySetting />}
</TabPane> */}
</TabContent>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { useTranslation } from 'next-i18next';

import AdminExternalAccountsContainer from '~/client/services/AdminExternalAccountsContainer';
import { toastSuccess, toastError } from '~/client/util/toastr';
import type { IExternalAuthProviderType } from '~/interfaces/external-auth-provider';

import { withUnstatedContainers } from '../../UnstatedUtils';

Expand Down Expand Up @@ -76,7 +77,7 @@ const ExternalAccountTable = (props: ExternalAccountTableProps): JSX.Element =>
</tr>
</thead>
<tbody>
{ adminExternalAccountsContainer.state.externalAccounts.map((ea: IAdminExternalAccount) => {
{ adminExternalAccountsContainer.state.externalAccounts.map((ea: IAdminExternalAccount<IExternalAuthProviderType>) => {
return (
<tr key={ea._id}>
<td><span>{ea.providerType}</span></td>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
import { useCallback } from 'react';

import { IExternalAuthProviderType } from '@growi/core';
import { useTranslation } from 'next-i18next';

import { IExternalAuthProviderType } from '~/interfaces/external-auth-provider';

const authIcon = {
[IExternalAuthProviderType.google]: <span className="growi-custom-icons align-bottom">google</span>,
[IExternalAuthProviderType.github]: <span className="growi-custom-icons align-bottom">github</span>,
[IExternalAuthProviderType.facebook]: <span className="growi-custom-icons align-bottom">facebook</span>,
[IExternalAuthProviderType.oidc]: <span className="growi-custom-icons align-bottom">openid</span>,
[IExternalAuthProviderType.saml]: <span className="material-symbols-outlined align-bottom">key</span>,
};

const authLabel = {
[IExternalAuthProviderType.google]: 'Google',
[IExternalAuthProviderType.github]: 'GitHub',
[IExternalAuthProviderType.facebook]: 'Facebook',
[IExternalAuthProviderType.oidc]: 'OIDC',
[IExternalAuthProviderType.saml]: 'SAML',
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,6 @@
--bs-btn-active-bg: #{rgba(#403D3E, 0.7)};
}

.btn-auth-facebook {
--bs-btn-bg: #{rgba(#29487d, 0.4)};
--bs-btn-hover-bg: #{rgba(#29487d, 0.9)};
--bs-btn-active-bg: #{rgba(#29487d, 0.9)};
}

.btn-auth-oidc {
--bs-btn-bg: #{rgba(#835B1A, 0.4)};
--bs-btn-hover-bg: #{rgba(#835B1A, 0.8)};
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/client/components/LoginForm/LoginForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import React, {
useState, useEffect, useCallback,
} from 'react';

import type { IExternalAuthProviderType } from '@growi/core';
import { LoadingSpinner } from '@growi/ui/dist/components';
import { useTranslation } from 'next-i18next';
import { useRouter } from 'next/router';
Expand All @@ -13,6 +12,7 @@ import { useTWithOpt } from '~/client/util/t-with-opt';
import type { IExternalAccountLoginError } from '~/interfaces/errors/external-account-login-error';
import { LoginErrorCode } from '~/interfaces/errors/login-error';
import type { IErrorV3 } from '~/interfaces/errors/v3-error';
import type { IExternalAuthProviderType } from '~/interfaces/external-auth-provider';
import { RegistrationMode } from '~/interfaces/registration-mode';
import { toArrayIfNot } from '~/utils/array-utils';

Expand Down
6 changes: 0 additions & 6 deletions apps/app/src/client/components/Me/AssociateModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,6 @@ const AssociateModal = (props: Props): JSX.Element => {
>
<span className="growi-custom-icons">google</span> (TBD) Google OAuth
</NavLink>
{/* <NavLink
className={`${activeTab === 4 ? 'active' : ''} d-flex gap-1 align-items-center`}
onClick={() => setActiveTab(4)}
>
<span className="growi-custom-icons">facebook</span> (TBD) Facebook
</NavLink> */}
</Nav>
<TabContent activeTab={activeTab}>
<TabPane tabId={1}>
Expand Down
5 changes: 3 additions & 2 deletions apps/app/src/client/components/Me/DisassociateModal.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { useCallback } from 'react';

import type { IExternalAccountHasId } from '@growi/core';
import type { HasObjectId, IExternalAccount } from '@growi/core';
import { useTranslation } from 'next-i18next';
import {
Modal,
Expand All @@ -10,12 +10,13 @@ import {
} from 'reactstrap';

import { toastSuccess, toastError } from '~/client/util/toastr';
import type { IExternalAuthProviderType } from '~/interfaces/external-auth-provider';
import { usePersonalSettings, useSWRxPersonalExternalAccounts } from '~/stores/personal-settings';

type Props = {
isOpen: boolean,
onClose: () => void,
accountForDisassociate: IExternalAccountHasId,
accountForDisassociate: IExternalAccount<IExternalAuthProviderType> & HasObjectId,
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const ShareLinkAlert: FC<Props> = (props: Props) => {
return (
<p className={`alert alert-${alertColor} px-4 d-edit-none`}>
<span className="material-symbols-outlined me-1">link</span>
{(expiredAt === null ? <span>{t('page_page.notice.no_deadline')}</span>
{(expiredAt == null ? <span>{t('page_page.notice.no_deadline')}</span>
// eslint-disable-next-line react/no-danger
: <span dangerouslySetInnerHTML={{ __html: t('page_page.notice.expiration', { expiredAt }) }} />
)}
Expand Down
Loading
Loading