feat: Implement EditScopePage #9594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…up selection logic
…nents for improved prop handling and UI consistency
…ling and improve component structure
…Share for improved layout and accessibility
…reScopeSwitch to include scope type in selection handlers
miya
changed the title
…fy user group selection handling and improve scope type management
…rate selectedAccessScope handling
…agementHome component
…nges with new props
miya
commented
Feb 3, 2025
...eatures/openai/client/components/AiAssistant/AiAssistantManagementModal/ShareScopeSwitch.tsx
Show resolved
Hide resolved
...res/openai/client/components/AiAssistant/AiAssistantManagementModal/SelectUserGroupModal.tsx
Show resolved
Hide resolved
.../client/components/AiAssistant/AiAssistantManagementModal/AiAssistantManagementEditShare.tsx
Show resolved
Hide resolved
.../client/components/AiAssistant/AiAssistantManagementModal/AiAssistantManagementEditShare.tsx
Outdated
Show resolved
Hide resolved
.../client/components/AiAssistant/AiAssistantManagementModal/AiAssistantManagementEditShare.tsx
Outdated
Show resolved
Hide resolved
...ures/openai/client/components/AiAssistant/AiAssistantManagementModal/AccessScopeDropdown.tsx
Show resolved
Hide resolved
...eatures/openai/client/components/AiAssistant/AiAssistantManagementModal/ShareScopeSwitch.tsx
Show resolved
Hide resolved
yuki-takei
requested changes
Feb 3, 2025
| // if not selected, add it | ||
| setSelectedUserGroups([...selectedUserGroups, targetUserGroup]); | ||
| } | ||
| }, [selectedUserGroupsForAccessScope, selectedUserGroupsForShareScope]); |
There was a problem hiding this comment.
このあたりの AiAssistantScopeType と AiAssistantAccessScope を無理矢理一緒に取り扱っているコードがちょっとよくないかなあ
...res/openai/client/components/AiAssistant/AiAssistantManagementModal/SelectUserGroupModal.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
#160853 [GROWI AI Next][特化型アシスタント] 確定されたデザインで新規アシスタント作成画面を表示できる
#159151 [GROWI AI Next][特化型アシスタント] 新規作成モーダルから作成ボタンをクリックした時アシスタントデータが作成される
ScreenRecord
2025-02-03.18.41.15.mov
Figma
https://www.figma.com/design/ZiEcjZ8sYt6YvowboA5Um6/GROWI-v7?node-id=2964-29977&t=aQR4K2nGN7wNoGER-0