Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative motor currents are not correctly converted, overflow to 65535 #50

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

bascetta74
Copy link
Contributor

A cast from uint to int in the parsing of motor currents is missing, this causes an overflow in case of negative currents.

Copy link
Contributor

@rdu-weston rdu-weston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the protocol documentation we received from AgileX, the current feedback is of type uint16_t. We will need to confirm with AgileX before merging this fix.

@rdu-weston
Copy link
Contributor

A cast from uint to int in the parsing of motor currents is missing, this causes an overflow in case of negative currents.

May I request for more information about the issue? e.g. which robot model are you using? what's the serial number of the robot? We need to identify which robot models are potentially affected by this issue before applying this change to the sdk. You can send the information to us via email [email protected]. Thank you very much!

@rdu-weston rdu-weston merged commit 15cfdcb into westonrobot:main Apr 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants