Fix missing clusters split while jumping back #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScanProcessor::splitConnected(float thresh) currently only consider the situation that range increase suddenly but ignore sudden decrease. When sudden decrease occurs, it will jump to "else" to "++s_rest". If range is far enough, "expand" will be 1 or 2, nothing happen. But if range is very close, it may miss a jumping back, which will led to incorrect clusters split.
I think we just need to add a "std::abs(float)" to the "if"