Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing clusters split while jumping back #59

Open
wants to merge 2 commits into
base: indigo-devel
Choose a base branch
from

Conversation

HaoQChen
Copy link

@HaoQChen HaoQChen commented May 7, 2018

ScanProcessor::splitConnected(float thresh) currently only consider the situation that range increase suddenly but ignore sudden decrease. When sudden decrease occurs, it will jump to "else" to "++s_rest". If range is far enough, "expand" will be 1 or 2, nothing happen. But if range is very close, it may miss a jumping back, which will led to incorrect clusters split.

I think we just need to add a "std::abs(float)" to the "if"

@HaoQChen
Copy link
Author

HaoQChen commented May 8, 2018

leg_detector->void pairLegs(). At the second loop that "Attempt to pair up legs with no id", did you forget to change "closest_dist" to "d" when a pair of better legs appear. If we don't do that, it will only remember the first pair and every thing else we do will be forgot. And I think we just need to loop "leg2" from "leg1 + 1", cause the distance is scalar not vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant