Support highcharts v12 #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might need to update the warning output in Maybe it just outputs that "this line is not required in High charts 12 and above"? |
I prepended the warning with '// For highcharts below version 12:' in 97b68aa |
|
Whoops, sorry thought I'd replied. Yep that change is great |
Should we merge and release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add highcharts v12 as peer dependency
One breaking change on highcharts side: modules run themselves instead of providing function to run.
For example:
The change does not need changes to the library, so I think we can release this as is. So maybe a release after merge?