Support react 19 #392
Merged
Support react 19 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
==========================================
- Coverage 86.99% 86.45% -0.54%
==========================================
Files 88 89 +1
Lines 1169 1211 +42
Branches 240 250 +10
==========================================
+ Hits 1017 1047 +30
- Misses 138 150 +12
Partials 14 14 ☔ View full report in Codecov by Sentry. |
whawker
reviewed
Dec 8, 2024
| @@ -48,8 +48,8 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "highcharts": "^9.1.2 || ^10.0.0 || ^11.0.0 || ^12.0.1", | |||
| "react": "^17.0.0 || ^18.0.0", | |||
| "react-dom": "^17.0.0 || ^18.0.0" | |||
| "react": "^17.0.0 || ^18.0.0 || ^19.0.0", | |||
There was a problem hiding this comment.
Optional, but could just do 17 - 19?
There was a problem hiding this comment.
Yeah, it is just so little used syntax, that finding examples with google is hard.
whawker
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests pass and the examples work.
I think it is good to go.