Cover the new private function shared by addTagFile and removeTagFile

whikloj · Apr 17, 2024 · da015fe · da015fe
1 parent 9380b60
commit da015fe
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/tests/BagTest.php b/tests/BagTest.php
@@ -1021,9 +1021,9 @@ public function testAddBagInfoWhenNotExtended(): void
     {
         $bag = Bag::create($this->tmpdir);
         $this->assertFalse($bag->isExtended());
-        $bag->addBagInfoTag("Contact-Name", "Jared Whiklo");
+        $bag->addBagInfoTag("Contact-Name", "Bob Smith");
         $this->assertTrue($bag->isExtended());
-        $this->assertArrayEquals(["Jared Whiklo"], $bag->getBagInfoByTag("Contact-Name"));
+        $this->assertArrayEquals(["Bob Smith"], $bag->getBagInfoByTag("Contact-Name"));
     }
 
     /**

diff --git a/tests/ExtendedBagTest.php b/tests/ExtendedBagTest.php
@@ -993,6 +993,7 @@ public function testExtendedBagWithoutBagInfo(): void
      * Test trying to add a tag file with a non-existant file.
      * @group Extended
      * @covers ::addTagFile
+     * @covers ::checkTagFileConstraints
      */
     public function testAddTagFileFileDoesNotExist(): void
     {
@@ -1006,6 +1007,7 @@ public function testAddTagFileFileDoesNotExist(): void
      * Test trying to add a tag file over the bag-info.txt file.
      * @group Extended
      * @covers ::addTagFile
+     * @covers ::checkTagFileConstraints
      */
     public function testAddTagFileCannotOverwriteBagInfo(): void
     {
@@ -1021,6 +1023,7 @@ public function testAddTagFileCannotOverwriteBagInfo(): void
      * Test trying to add a tag file over the bagit.txt file.
      * @group Extended
      * @covers ::addTagFile
+     * @covers ::checkTagFileConstraints
      */
     public function testAddTagCannotOverwriteBagIt(): void
     {
@@ -1036,6 +1039,7 @@ public function testAddTagCannotOverwriteBagIt(): void
      * Test trying to add a tag file over a payload manifest file.
      * @group Extended
      * @covers ::addTagFile
+     * @covers ::checkTagFileConstraints
      */
     public function testAddTagCannotOverwritePayloadManifest(): void
     {
@@ -1052,6 +1056,7 @@ public function testAddTagCannotOverwritePayloadManifest(): void
      * Test trying to add a tag file over a tag manifest file.
      * @group Extended
      * @covers ::addTagFile
+     * @covers ::checkTagFileConstraints
      */
     public function testAddTagCannotOverwriteTagManifest(): void
     {
@@ -1069,6 +1074,7 @@ public function testAddTagCannotOverwriteTagManifest(): void
      * Test trying to add a tag file to the data directory.
      * @group Extended
      * @covers ::addTagFile
+     * @covers ::checkTagFileConstraints
      */
     public function testAddTagCannotBeInDataDirectory(): void
     {
@@ -1083,6 +1089,7 @@ public function testAddTagCannotBeInDataDirectory(): void
      * Test trying to add a tag file to the data directory.
      * @group Extended
      * @covers ::addTagFile
+     * @covers ::checkTagFileConstraints
      */
     public function testAddTagCannotBeInDataDirectory2(): void
     {
@@ -1113,6 +1120,7 @@ public function testAddTagNotOverwrite(): void
      * Test adding a tag file to the bag.
      * @group Extended
      * @covers ::addTagFile
+     * @covers ::checkTagFileConstraints
      */
     public function testAddTagFileSuccess(): void
     {

diff --git a/tests/ManifestTest.php b/tests/ManifestTest.php
@@ -51,7 +51,7 @@ public function testCheckManifests(): void
             'tag' => $bag->getBagRoot() . '/tagmanifest-sha256.txt',
         ];
         $bag->setExtended(true);
-        $bag->addBagInfoTag('Contact-name', 'Jared Whiklo');
+        $bag->addBagInfoTag('Contact-name', 'Bob Smith');
         $bag->setAlgorithm('sha256');
         $bag->createFile("This is some sample text", 'some/directory/file.txt');