Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ineffective argument from sample #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jansauer
Copy link

Based on the documentation of the individual env vars, OVERPASS_META only applies on init mode. Since this docker run example is using the clone mode the OVERPASS_META is ineffective and only makes the sample more complex and confusing.

Based on the documentation of the individual env vars, `OVERPASS_META` only applies on `init` mode. Since this docker run example is using the `clone` mode the `OVERPASS_META` is ineffective and only makes the sample more complex and confusing.
@wiktorn
Copy link
Owner

wiktorn commented Jan 15, 2025

OVERPASS_META argument is also used when running update scripts as well as starting dispatcher. I'm not sure, if removing it will not affect the functionality. I do not have necessary infrastructure to test cloned instance.

@jansauer
Copy link
Author

jansauer commented Jan 18, 2025

Oh, I forgot to think about the update the script.

* `OVERPASS_META` - (`init` mode only) `yes`, `no` or `attic` - passed to Overpass as `--meta` or `--keep-attic`.

Based on the init mode only line i thought that setting this env var in mode clone does not have any effect. Since I'm running my instance in clone mode and without this setting I will try to understand if this results in any problems for my instance.

@wiktorn thx for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants