Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dimension Mismatch in ETD Calculation Error #393

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Fix Dimension Mismatch in ETD Calculation Error #393

merged 6 commits into from
Jan 23, 2025

Conversation

Yun-Wu
Copy link
Contributor

@Yun-Wu Yun-Wu commented Jan 22, 2025 •
edited
Loading

Fixes #394

It also includes two minor changes:

  1. Add "exclusion_flags", "additional" columns when uploading observations in earthranger
  2. A minor fix in draw_historic_timeseries docstring

@Yun-Wu Yun-Wu changed the title Fix ETD calculation error Fix Dimension Mismatch in ETD Calculation Error Jan 22, 2025
atmorling
atmorling approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@atmorling atmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ecoscope/analysis/UD/etd_range.py Show resolved Hide resolved
ecoscope/analysis/UD/etd_range.py Show resolved Hide resolved
@Yun-Wu Yun-Wu merged commit c30e553 into master Jan 23, 2025
5 checks passed
@Yun-Wu Yun-Wu deleted the yw/ate branch January 23, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmorling atmorling atmorling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Dimension Mismatch in ETD Calculation Error
2 participants
@Yun-Wu @atmorling