Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract common aws logic across cloud api #7245

Merged
merged 7 commits into from
Jan 19, 2025
Merged

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jan 19, 2025

Create base classes for all cloud API resources to share common logic across AWS platforms

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Create base classes for all cloud API resources to share common logic across AWS platforms
@eladb eladb requested a review from a team as a code owner January 19, 2025 14:32
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping use over Discord.

@monadabot
Copy link
Contributor

monadabot commented Jan 19, 2025

Console preview environment is available at https://wing-console-pr-7245.fly.dev 🚀

Last Updated (UTC) 2025-01-19 15:44

@monadabot
Copy link
Contributor

monadabot commented Jan 19, 2025

Benchmarks

Comparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 55ms±0.82 55ms±0.42 0ms (-0.37%)⬜
functions_10.test.w -t sim 475ms±16.56 500ms±19.85 +26ms (+5.38%)🟥
functions_10.test.w -t tf-aws 2171ms±32.48 2158ms±15.96 -14ms (-0.63%)⬜
empty.test.w -t sim 365ms±5.08 360ms±5.23 -5ms (-1.44%)⬜
empty.test.w -t tf-aws 586ms±2.85 588ms±4.49 +2ms (+0.29%)⬜
jsii_small.test.w -t sim 365ms±4.27 368ms±5.08 +3ms (+0.75%)⬜
jsii_small.test.w -t tf-aws 595ms±8.9 597ms±4.58 +2ms (+0.42%)⬜
functions_1.test.w -t sim 400ms±2.41 398ms±4.2 -2ms (-0.49%)⬜
functions_1.test.w -t tf-aws 830ms±4.32 827ms±5.15 -3ms (-0.37%)⬜
jsii_big.test.w -t sim 2922ms±15.1 2901ms±13.18 -20ms (-0.7%)⬜
jsii_big.test.w -t tf-aws 3107ms±11.53 3120ms±16.19 +13ms (+0.41%)⬜
hello_world.test.w -t sim 401ms±3.71 398ms±6.93 -3ms (-0.8%)⬜
hello_world.test.w -t tf-aws 1481ms±6.18 1472ms±7.39 -8ms (-0.57%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 55ms 54ms 56ms 0ms 1ms
functions_10.test.w -t sim 500ms 476ms 559ms 20ms 28ms
functions_10.test.w -t tf-aws 2158ms 2123ms 2203ms 16ms 22ms
empty.test.w -t sim 360ms 345ms 374ms 5ms 7ms
empty.test.w -t tf-aws 588ms 579ms 600ms 4ms 6ms
jsii_small.test.w -t sim 368ms 356ms 379ms 5ms 7ms
jsii_small.test.w -t tf-aws 597ms 588ms 609ms 5ms 6ms
functions_1.test.w -t sim 398ms 392ms 408ms 4ms 6ms
functions_1.test.w -t tf-aws 827ms 814ms 836ms 5ms 7ms
jsii_big.test.w -t sim 2901ms 2871ms 2931ms 13ms 18ms
jsii_big.test.w -t tf-aws 3120ms 3088ms 3163ms 16ms 23ms
hello_world.test.w -t sim 398ms 384ms 417ms 7ms 10ms
hello_world.test.w -t tf-aws 1472ms 1463ms 1493ms 7ms 10ms
Last Updated (UTC) 2025-01-19 15:49

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jan 19, 2025
@eladb eladb requested a review from skyrpex January 19, 2025 15:02
@eladb eladb removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jan 19, 2025
@eladb eladb merged commit 023ab50 into main Jan 19, 2025
23 checks passed
@eladb eladb deleted the eladb/aws-common branch January 19, 2025 15:56
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants