Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): test workflow failing due to bad turbo config #7251

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

skyrpex
Copy link
Contributor

@skyrpex skyrpex commented Jan 23, 2025

The wingc's lint task depends on tree-sitter-wing's build:generate task, but it wasn't specified in the turbo config. It was working due to the previous build workflow which ran a full build and provided the necessary assets through the cache.

Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping use over Discord.

@skyrpex skyrpex changed the title fix(tree-sitter-wing): compile task now depends on build:wasm fix(repo): compile task now depends on build:wasm Jan 23, 2025
@skyrpex skyrpex changed the title fix(repo): compile task now depends on build:wasm fix(repo): test workflow failing due to bad turbo config Jan 23, 2025
@skyrpex skyrpex marked this pull request as ready for review January 23, 2025 09:58
@skyrpex skyrpex requested a review from a team as a code owner January 23, 2025 09:58
@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-7251.fly.dev 🚀

Last Updated (UTC) 2025-01-23 10:01

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 59ms±2.84 58ms±0.63 -1ms (-1.37%)⬜
functions_10.test.w -t sim 481ms±16.91 526ms±33.06 +44ms (+9.23%)🟥
functions_10.test.w -t tf-aws 2200ms±40.05 2203ms±27.12 +4ms (+0.17%)⬜
empty.test.w -t sim 375ms±4.53 372ms±3.46 -3ms (-0.84%)⬜
empty.test.w -t tf-aws 604ms±4.64 601ms±4.14 -4ms (-0.64%)⬜
jsii_small.test.w -t sim 372ms±3.38 373ms±2.91 +0ms (+0.1%)⬜
jsii_small.test.w -t tf-aws 607ms±10.35 613ms±6.78 +6ms (+1.07%)⬜
functions_1.test.w -t sim 397ms±3.93 398ms±3.89 +0ms (+0.06%)⬜
functions_1.test.w -t tf-aws 855ms±5.51 853ms±11.04 -2ms (-0.24%)⬜
jsii_big.test.w -t sim 2952ms±27.07 2951ms±22.22 -1ms (-0.04%)⬜
jsii_big.test.w -t tf-aws 3126ms±13.75 3150ms±24.13 +24ms (+0.78%)⬜
hello_world.test.w -t sim 412ms±3.7 411ms±3.84 -1ms (-0.18%)⬜
hello_world.test.w -t tf-aws 1497ms±7.67 1500ms±12.59 +3ms (+0.17%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 58ms 56ms 59ms 1ms 1ms
functions_10.test.w -t sim 526ms 441ms 602ms 33ms 46ms
functions_10.test.w -t tf-aws 2203ms 2149ms 2273ms 27ms 38ms
empty.test.w -t sim 372ms 364ms 378ms 3ms 5ms
empty.test.w -t tf-aws 601ms 593ms 611ms 4ms 6ms
jsii_small.test.w -t sim 373ms 367ms 380ms 3ms 4ms
jsii_small.test.w -t tf-aws 613ms 606ms 637ms 7ms 9ms
functions_1.test.w -t sim 398ms 391ms 407ms 4ms 5ms
functions_1.test.w -t tf-aws 853ms 832ms 887ms 11ms 15ms
jsii_big.test.w -t sim 2951ms 2916ms 3006ms 22ms 31ms
jsii_big.test.w -t tf-aws 3150ms 3100ms 3216ms 24ms 34ms
hello_world.test.w -t sim 411ms 402ms 419ms 4ms 5ms
hello_world.test.w -t tf-aws 1500ms 1476ms 1536ms 13ms 18ms
Last Updated (UTC) 2025-01-23 10:06

@skyrpex skyrpex merged commit 80b06d0 into main Jan 23, 2025
14 of 15 checks passed
@skyrpex skyrpex deleted the fix-tree-sitter-wing-task-dependencies branch January 23, 2025 12:31
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants