Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle timestamp incremental replication #89

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

mjsqu
Copy link
Collaborator

@mjsqu mjsqu commented Oct 10, 2024

Fixes #86

TIMESTAMP is a misleading column data type name in SQL Server - it has no equivalent date/time value

  • Timestamp columns are treated as strings (e.g. 00000000000007d2)
  • Convert VARBINARY/BIGINT is used to read in a held state value and compare it to a value in the synced table
  • Tests added to show that incremental replication is working
  • Redundant logic removed from existing incremental tests

@mjsqu mjsqu requested a review from s7clarke10 October 10, 2024 00:12
Copy link
Collaborator

@s7clarke10 s7clarke10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preparing this change. Can we please update the following files. It will be required for the CI to push a change into PyPI.

  • .bumpversion.cfg - update the release number
  • pyproject.toml - update the release number
  • CHANGELOG.md - Add release notes against the release number.

@mjsqu mjsqu requested a review from s7clarke10 October 24, 2024 00:06
@s7clarke10 s7clarke10 merged commit f9a59ba into wintersrd:master Oct 24, 2024
1 check passed
s7clarke10 pushed a commit to s7clarke10/pipelinewise-tap-mssql that referenced this pull request Oct 24, 2024
* Handle timestamp (nothing to do with datetime -- SQL Server rowversion) incremental replication

* Release 2.6.4 prep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot parse timestamp type
2 participants