Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(druid-task-exporter): add chart #370

Merged
merged 1 commit into from
Nov 16, 2023
Merged

feat(druid-task-exporter): add chart #370

merged 1 commit into from
Nov 16, 2023

Conversation

capuche2412
Copy link
Contributor

No description provided.

@capuche2412 capuche2412 force-pushed the feat/add-druid-tasks-exporter-chart branch 2 times, most recently from dca017d to 96d5169 Compare November 9, 2023 09:15
@capuche2412 capuche2412 requested review from maxime1907 and removed request for maxime1907 November 9, 2023 09:16
@capuche2412 capuche2412 force-pushed the feat/add-druid-tasks-exporter-chart branch from 96d5169 to e170dbb Compare November 9, 2023 09:43
@maxime1907
Copy link
Member

  1. CI doesnt pass tests
  2. Chart should live on its own so basically just copy paste it from https://github.com/machine424/druid-tasks-exporter/tree/main/chart/druid-tasks-exporter inside https://github.com/wiremind/wiremind-helm-charts/tree/main/charts/druid-tasks-exporter
  3. When standalone chart is deployed, use it as a subchart inside druid like this one https://github.com/wiremind/wiremind-helm-charts/blob/main/charts/druid/Chart.yaml#L36

@maxime1907
Copy link
Member

maxime1907 commented Nov 10, 2023 •
edited
Loading

i think we should also duplicate the repository here (https://github.com/machine424/druid-tasks-exporter/tree/main) and put it on our side since ayoub is not working at wiremind anymore so that we can control our docker images to avoid using something like machine424/druid-tasks-exporter:0.4.0-dev-3 that has most likely been pushed by hand without CI to dockerhub (https://hub.docker.com/r/machine424/druid-tasks-exporter/tags)

@maxime1907 maxime1907 removed their request for review November 10, 2023 09:49
@capuche2412 capuche2412 force-pushed the feat/add-druid-tasks-exporter-chart branch 5 times, most recently from 02ee684 to ad27147 Compare November 10, 2023 14:31
@capuche2412 capuche2412 changed the title feat(druid): add tasks-exporter to chart feat(druid-task-exporter): add chart Nov 10, 2023
@capuche2412 capuche2412 force-pushed the feat/add-druid-tasks-exporter-chart branch 9 times, most recently from 58a116e to 18bd765 Compare November 13, 2023 13:40
@maxime1907 maxime1907 requested review from maxime1907 and removed request for maxime1907 November 14, 2023 10:12
@capuche2412 capuche2412 force-pushed the feat/add-druid-tasks-exporter-chart branch 2 times, most recently from bad0bac to 7b6b282 Compare November 14, 2023 15:31
@capuche2412 capuche2412 requested review from maxime1907 and removed request for maxime1907 November 14, 2023 15:38
@capuche2412 capuche2412 force-pushed the feat/add-druid-tasks-exporter-chart branch from 7b6b282 to 8204207 Compare November 14, 2023 15:55
@capuche2412 capuche2412 force-pushed the feat/add-druid-tasks-exporter-chart branch from 8204207 to 8cc620f Compare November 15, 2023 10:26
@capuche2412 capuche2412 force-pushed the feat/add-druid-tasks-exporter-chart branch from 8cc620f to a6b9554 Compare November 16, 2023 15:34
@capuche2412 capuche2412 force-pushed the feat/add-druid-tasks-exporter-chart branch from a6b9554 to eb88134 Compare November 16, 2023 15:35
@capuche2412 capuche2412 merged commit eb58758 into main Nov 16, 2023
@capuche2412 capuche2412 deleted the feat/add-druid-tasks-exporter-chart branch November 16, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime1907 maxime1907 maxime1907 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capuche2412 @maxime1907