Wallet creation time #920
Merged
Wallet creation time #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythcoiner
force-pushed
the
wallet_birthday
branch
3 times, most recently
from
8bdf7b5 to
b61ea3d
Compare
|
Concept ACK. I think the GUI integration should go in a latter PR (since it needs to update the daemon). So a small addition to |
pythcoiner
force-pushed
the
wallet_birthday
branch
from
b61ea3d to
7917794
Compare
|
docs added, now ready for review |
darosior
reviewed
Jan 23, 2024
Comment on lines
+8
to
+14
| use std::convert::TryInto; | ||
| use std::{ | ||
| collections::{HashMap, HashSet}, | ||
| env, fs, io, path, process, | ||
| str::FromStr, | ||
| sync, thread, time, | ||
| time::{SystemTime, UNIX_EPOCH}, |
There was a problem hiding this comment.
Nit, for next time:
Suggested change
| use std::convert::TryInto; | |
| use std::{ | |
| collections::{HashMap, HashSet}, | |
| env, fs, io, path, process, | |
| str::FromStr, | |
| sync, thread, time, | |
| time::{SystemTime, UNIX_EPOCH}, | |
| use std::{ | |
| collections::{HashMap, HashSet}, | |
| convert::TryInto, env, fs, io, path, process, | |
| str::FromStr, | |
| sync, thread, time, | |
| time::{SystemTime, UNIX_EPOCH}, |
| @@ -22,6 +22,7 @@ | |||
|
|
|||
| def test_getinfo(lianad): | |||
| res = lianad.rpc.getinfo() | |||
| assert 'timestamp' in res.keys() | |||
There was a problem hiding this comment.
nit: could've sanity checked the value. For instance that it's after now - 1 day and lower or equal to now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(partially) address #805