DISABLE_BACKUP is now powerfail-safe. #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By not checking/updating sector flags during copies from UPDATE to BOOT partitions, a copy operation getting interrupted by power failure will be less likely to cause problems to the integrity of the BOOT image. This is because in case of interruptions, the copy operation will be restarted from the first sector.
jpbland1
reviewed
Feb 22, 2024
| ./wolfboot.elf powerfail 1a000 get_version 2>/dev/null | ||
| # fail on the last sector to stop the encrypt key save and state update | ||
| ./wolfboot.elf powerfail 3e000 get_version 2>/dev/null | ||
| # may not trigger on non NVM_FLASH_WRITEONCE |
There was a problem hiding this comment.
does NVM_FLASH_WRITEONCE get used with DISABLE_BACKUP? Would need to add a combo test for it, otherwise remove my ugly hack here. Also missing combo cases for things like HOME_FLAGS, not sure if it's relevant for this flag but otherwise looks good.
|
Thanks @jpbland1 - I've added two more test cases to check the combination of DISABLE_BACKUP with the two options mentioned above. Please consider for merging. |
jpbland1
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
DISABLE_BACKUP=1, by not checking/updating sector flags during copies from UPDATE to BOOT partitions, a copy operation getting interrupted by power failure will be less likely to cause problems to the integrity of the BOOT image. This is because in case of interruptions, the copy operation will be restarted from the first sector.Idea taken from ZD17551.