Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign and Verify Support with PEM format key ED25519, RSA, and ECC #148

Merged
merged 8 commits into from
Aug 29, 2024
Merged

Sign and Verify Support with PEM format key ED25519, RSA, and ECC #148

merged 8 commits into from
Aug 29, 2024

Conversation

aidangarske
Copy link

@aidangarske aidangarske commented Aug 1, 2024 •
edited
Loading

Description

Sign and Verify Support with PEM and DER keys ED25519, RSA, and ECC.
RAW support for ED25519.

Testing

wolfSSL config

./configure --enable-wolfclu --enable-keygen --enable-all --enable-debug

wolfCLU

./configure --enable-all --enable-debug 
make
make check 
./tests/genkey_sign_ver/genkey-sign-ver-test.sh

@aidangarske aidangarske requested a review from lealem47 August 1, 2024 20:50
@aidangarske aidangarske self-assigned this Aug 1, 2024
dgarske
dgarske requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should run these changes with valgrind, -fsanitize=address and scan-build. Someone can show you how to use these tools.

src/genkey/clu_genkey.c Outdated Show resolved Hide resolved
src/genkey/clu_genkey.c Outdated Show resolved Hide resolved
src/genkey/clu_genkey.c Outdated Show resolved Hide resolved
src/sign-verify/clu_sign.c Outdated Show resolved Hide resolved
src/sign-verify/clu_verify.c Outdated Show resolved Hide resolved
@aidangarske aidangarske changed the title Draft Sign and Verify Support with PEM format key ED25519 Draft Sign and Verify Support with PEM format key ED25519, RSA, and ECC Aug 7, 2024
@aidangarske aidangarske changed the title Draft Sign and Verify Support with PEM format key ED25519, RSA, and ECC Sign and Verify Support with PEM format key ED25519, RSA, and ECC Aug 7, 2024
@aidangarske aidangarske requested a review from dgarske August 7, 2024 23:24
@dgarske dgarske marked this pull request as ready for review August 8, 2024 20:51
lealem47
lealem47 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@lealem47 lealem47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions and refactors! Thanks

@lealem47 lealem47 merged commit 6f4757a into wolfSSL:main Aug 29, 2024
6 checks passed
@lealem47 lealem47 mentioned this pull request Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lealem47 lealem47 lealem47 approved these changes

@dgarske dgarske dgarske approved these changes

Assignees

@dgarske dgarske

@wolfSSL-Bot wolfSSL-Bot

@lealem47 lealem47

@aidangarske aidangarske

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aidangarske @dgarske @lealem47 @wolfSSL-Bot