Custom user callbacks (custom requests) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esting an unregistered callbacks return error
bigbrett
force-pushed
the
custom-message-handling
branch
from
903e5cb to
12c810e
Compare
billphipps
requested changes
Apr 3, 2024
- made custom callback table part of server context - reduced number of callbacks to 8 - deleted wh_server_custom.h and moved contents to wh_server.h - Added wh_Client_CustomResponseCheckRegistered() helper
billphipps
previously approved these changes
Apr 4, 2024
wolfhsm/wh_server.h
Outdated
| @@ -12,6 +12,7 @@ | |||
| #include "wolfhsm/wh_common.h" | |||
| #include "wolfhsm/wh_comm.h" | |||
| #include "wolfhsm/wh_nvm.h" | |||
| #include "wolfhsm/wh_message_custom.h" | |||
There was a problem hiding this comment.
I didn't see where this was needed in this header.
- Renamed custom structs and functions to customcb - renamed files - added blocking client helper - changed request/response id from uint16_t to uint32_t
bigbrett
force-pushed
the
custom-message-handling
branch
from
b1a94bb to
1029307
Compare
billphipps
approved these changes
Apr 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at simple user callback implementation. It allows for multiple (up to 255) "custom request callbacks" to be registered by the server, and allows for these callbacks to be requested by the client via the client API. It supports passing arbitrary data in and out of the server callback. It also provides a query functionality to check if a given callback has been registered.