Sha256 support #62
Merged
Sha256 support #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billphipps
previously approved these changes
Aug 9, 2024
| /* Length of the last input block of data. Only valid if isLastBlock=1 */ | ||
| uint32_t lastBlockLen; | ||
| /* Full sha256 input block to hash */ | ||
| uint8_t inBlock[64]; /* TODO (BRN) WC_SHA256_BLOCK_SIZE */ |
There was a problem hiding this comment.
Why not use the WC_SHA256_BLOCK_SIZE? Same of other todos
There was a problem hiding this comment.
because then we need to pull wolfCrypt headers into this file, which will mean we need to macro gate a ton of stuff AND it will break our padding test, since it will check padding of all the wolfCrypt structs in the headers we pull in :( I can just use a local macro for now until we figure out a better way to do it
There was a problem hiding this comment.
Understood. Recommend add additional #define's in here if you want to keep these sizes statically defined.
bigbrett
force-pushed
the
sha256-support
branch
from
7650a28 to
d4b8041
Compare
billphipps
approved these changes
Aug 10, 2024
| /* Length of the last input block of data. Only valid if isLastBlock=1 */ | ||
| uint32_t lastBlockLen; | ||
| /* Full sha256 input block to hash */ | ||
| uint8_t inBlock[64]; /* TODO (BRN) WC_SHA256_BLOCK_SIZE */ |
There was a problem hiding this comment.
Understood. Recommend add additional #define's in here if you want to keep these sizes statically defined.
jefferyq2
pushed a commit
to jefferyq2/wolfHSM
that referenced
this pull request
Nov 10, 2024
Sha256 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds non-DMA sha256 support to wolfHSM crypto. Intermediate SHA state is held by the client and passed back and forth on each SHA256 API call. Passes tests and wolfCrypt tests
Note: The message in
wh_packet.hare fixed size (with no padding needed the way they are implemented), and so I didn't use the "trailing implicit buffer" scheme that the other messages use, as it adds some more complicated array indexing logic since there are two optional buffers that would need to be passed back and forth. This results in a few extra unused bytes being sent on the first update message (unused resume hash state), and potentially on the finalize message (remainder of the SHA block not used for data).I can go back and modify this to use the implicit buffers and variable length data if needed, but the code is a little simpler this way so figured I would see what you though first.