Update curve25519 and posixshm transport #73
Conversation
billphipps
commented
Sep 11, 2024
billphipps
commented
- Update curve25519 to match ecc code structure.
- Update posix shm transport to work on MacOS and add optional DMA mappings
- Clean up tests
- Correct other typos
billphipps
requested review from
jpbland1 and
bigbrett
and removed request for
jpbland1
|
|
||
| /* Unmap the header and remap the full area */ | ||
| (void)munmap((void*)header, sizeof(*header)); | ||
| ret = posixTransportShm_Map(fd, size, map); |
There was a problem hiding this comment.
what is the rationale behind mapping just the header first, then unmapping and remapping the entire area? Vs just mapping the whole thing in one go?
There was a problem hiding this comment.
The client doesn't know the sizes of the buffers, so it maps the header first to find out, then remaps once the sizes are understood.
| return wh_TransportMem_SendRequest(ctx->transportMemCtx, len, data); | ||
| /* Check connected status */ | ||
| switch(ctx->state) { | ||
| case PTSHM_STATE_NONE: |
There was a problem hiding this comment.
A bit confused about this logic (as well as the client initialization. Since the client init is what initially zeros the context and calls posixTransportShm_{Use/Handle}Map() on it, and we don't ever want a user to be sending requests without first initializing the client context, should we even be handling the NONE state here? I'd have figured that this logic should have been in the INITIALIZED state, since that is what the client init handler sets the state to once it successfully initializes. Is this some sort of deferred initialization that is allowed if the original client init fails? If so perhaps we just call client init again here?
There was a problem hiding this comment.
The server creates and zeroes the object. The client only has to map it. NONE is used when the client was not able to open the object OR the object was not completely setup by the server. This forces the client to attempt to reopen, map the header, and then remap the entire object. Once the client is able to successfully map the entire segment, it sets the intiitalzed member in the header and leaves the mapping intact. Recall, the client init only tries once to open and map the object, so the entire sequence is tried again here as well. Sorry for the misleading comments.
|
Verified crypto tests pass on tc3xx |
Co-authored-by: Brett Nicholas <[email protected]>
test/wh_test_crypto.c
Outdated
| @@ -26,6 +26,7 @@ | |||
| #include <stdint.h> | |||
| #include <stdio.h> /* For printf */ | |||
| #include <string.h> /* For memset, memcpy */ | |||
| #include <unistd.h> /* For sleep */ | |||
There was a problem hiding this comment.
needs to be protected by WOLFHSM_CFG_TEST_POSIX (block already present later in this file)
Update curve25519 and posixshm transport
