Use BUFFER_E instead of ASN_PARSE_E when buffer is too small

wolfSSL · Jan 20, 2025 · 9c4ef7c · 9c4ef7c
1 parent 462aa5b
commit 9c4ef7c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/tests/api.c b/tests/api.c
@@ -26522,9 +26522,9 @@ static int test_wc_ecc_rs_to_sig(void)
         WC_NO_ERR_TRACE(ECC_BAD_ARG_E));
 #if !defined(HAVE_SELFTEST) && !defined(HAVE_FIPS)
     ExpectIntEQ(wc_ecc_sig_to_rs(sig, siglen, r, &zeroLen, s, &slen),
-        WC_NO_ERR_TRACE(ASN_PARSE_E));
+        WC_NO_ERR_TRACE(BUFFER_E));
     ExpectIntEQ(wc_ecc_sig_to_rs(sig, siglen, r, &rlen, s, &zeroLen),
-        WC_NO_ERR_TRACE(ASN_PARSE_E));
+        WC_NO_ERR_TRACE(BUFFER_E));
 #endif
 #endif
     return EXPECT_RESULT();

diff --git a/wolfcrypt/src/asn.c b/wolfcrypt/src/asn.c
@@ -1300,7 +1300,7 @@ static int GetASN_StoreData(const ASNItem* asn, ASNGetData* data,
                 WOLFSSL_MSG_VSNPRINTF("Buffer too small for data: %d %d", len,
                         *data->data.buffer.length);
             #endif
-                return ASN_PARSE_E;
+                return BUFFER_E;
             }
             /* Copy in data and record actual length seen. */
             XMEMCPY(data->data.buffer.data, input + idx, (size_t)len);
@@ -33784,7 +33784,7 @@ int DecodeECC_DSA_Sig_Bin(const byte* sig, word32 sigLen, byte* r, word32* rLen,
             *rLen = (word32)len;
         else {
             /* Buffer too small to hold r value */
-            return ASN_PARSE_E;
+            return BUFFER_E;
         }
     }
     if (r)
@@ -33798,8 +33798,8 @@ int DecodeECC_DSA_Sig_Bin(const byte* sig, word32 sigLen, byte* r, word32* rLen,
         if (*sLen >= (word32)len)
             *sLen = (word32)len;
         else {
-            /* Buffer too small to hold r value */
-            return ASN_PARSE_E;
+            /* Buffer too small to hold s value */
+            return BUFFER_E;
         }
     }
     if (s)