20240723-AesGcmXcrypt-NULL-in-checks #7783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck and return BAD_FUNC_ARG for nonzero sizes associated with null pointers.
|
retest this please |
kaleb-himes
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfcrypt/src/aes.c: inwc_AesGcmEncrypt()andwc_AesGcmDecrypt(), check and returnBAD_FUNC_ARGfor nonzero sizes associated with null pointers.detected and tested with
wolfssl-multi-test.sh ... fips-140-3-dev-optest-acvp-sp-asm-- the x86 asm implementation has insufficient error checking, and the changes in this PR protect it.see also https://github.com/wolfSSL/fips/pull/274 for
optest-140-3that is clean on this PR.