Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20240823-WOLFSSL_DEBUG_TRACE_ERROR_CODES_ALWAYS #7897

Conversation

douzzer
Copy link
Contributor

@douzzer douzzer commented Aug 23, 2024

add WOLFSSL_DEBUG_TRACE_ERROR_CODES_ALWAYS flag for optional errcode tracing in apps, define it in wolfcrypt/test/test.c when defined(WOLFSSL_DEBUG_TRACE_ERROR_CODES), and deploy WC_NO_ERR_TRACE() to test.c where needed.

note, test.c is included in the linuxkm with --enable-crypttests as part of the library (module), so these changes fix preexisting test.c trace noise in the linuxkm.

tested with wolfssl-multi-test.sh ... check-source-text quantum-safe-wolfssl-all-clang-tidy linuxkm-mainline-intelasm-sp-asm-pie-gcc-latest-insmod (note that linuxkm-mainline-intelasm-sp-asm-pie-gcc-latest-insmod includes --enable-debug-trace-errcodes.)

…tracing in apps, define it in wolfcrypt/test/test.c when defined(WOLFSSL_DEBUG_TRACE_ERROR_CODES), and deploy WC_NO_ERR_TRACE() to test.c where needed.
@douzzer
Copy link
Contributor Author

douzzer commented Aug 23, 2024

retest this please

Copy link
Member

@embhorn embhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally also

@embhorn embhorn merged commit dcea21a into wolfSSL:master Aug 27, 2024
127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants