Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for PowerPC #7931

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Fixes for PowerPC #7931

merged 4 commits into from
Sep 10, 2024

Conversation

barracuda156
Copy link
Contributor

Description

There are trivial fixes which do not introduce any new code or functionally modify existing one.
What this does is:

  1. Fix PowerPC macros so that they also work on Darwin.
  2. Unbreak assembler parts on Darwin, where registers must be prefixed, unlike ELF ABI.

P. S. While it is possible to simply add register prefices via a new macro (which will expand to nothing on Linux/BSD) instead of a separate implementation, I think this way is preferable, since it will prevent Darwin ABI from being accidentally broken when someone updates this later on, adding VSX instructions, for example, or crypto of later ISA. It also matches existing code style, which, for example, keeps ppc32 and ppc64 in separate chunks, not mixing them.

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@barracuda156
Copy link
Contributor Author

barracuda156 commented Sep 1, 2024

@dgarske Since you have changed that code in asm.c in a2ed222 earlier, did you have anything else in mind besides macOS? AFAIK, no one else uses prefixed registers, but if something does, I need to add a macro for that case as well.

@JacobBarthelmeh (Tagging you in relation to the earlier commit.)

@dgarske
Copy link
Contributor

dgarske commented Sep 3, 2024

Hi @barracuda156, thanks for your PR's. In order to accept a third party contribution we need a signed agreement. Please email support at wolfssl dot com to get that process started.
Thank you, David Garske, wolfSSL

@barracuda156
Copy link
Contributor Author

@dgarske Done

@anhu
Copy link
Member

anhu commented Sep 9, 2024

Contributor agreement has been approved. We're good to move forward on this.

@dgarske dgarske requested review from SparkiDev and douzzer September 9, 2024 21:21
@dgarske dgarske assigned SparkiDev and unassigned dgarske Sep 9, 2024
@SparkiDev SparkiDev removed the request for review from douzzer September 10, 2024 00:34
@SparkiDev SparkiDev merged commit 10c1fa2 into wolfSSL:master Sep 10, 2024
115 checks passed
@barracuda156 barracuda156 deleted the powerpc-darwin branch September 10, 2024 00:35
@barracuda156 barracuda156 restored the powerpc-darwin branch September 10, 2024 00:35
@barracuda156 barracuda156 deleted the powerpc-darwin branch September 10, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants