Add lock around static ECC ecc_oid_cache #8051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a lock around the static
ecc_oid_cache
that is used bywc_ecc_get_oid()
inwolfcrypt/src/ecc.c
whenHAVE_OID_ENCODING
is defined.Threading issues around this were showing up in wolfSSL JNI testing, with exceptions/errors similar to the following:
Testing
Tested via existing unit tests, and wolfSSL JNI threaded ECC tests which exposed this issue.
Checklist