Ada binding: add support for PSK client callback #8332
Conversation
Tested with: `wolfSSL/wolfssl-examples/psk/server-psk.c` after changing `DTLSv1_3_Client_Method` to `DTLSv1_2_Client_Method` to comply with the server example.
|
Can one of the admins verify this patch? |
|
Hi @mgrojo , Thank you for your code contribution. In order to consider this we will need to have an agreement on file. Can you please email support at wolfssl dot com and reference this PR requesting a contributor agreement. Please include information about your location and current project. Thanks, |
|
Hi @mgrojo , Your contributor agreement has been approved. We will review these changes and provide feedback shortly. Okay to test Thanks, |
|
Tagging some of our Ada contributors for awareness : @joakim-strandberg @dalybrown @Irvise |
- Add comments for the PSK value in the example. - Add runtime argument for executing the PSK test. - Warn user that their callback implementation can't be in the SPARK subset.
|
Retest this please: "FIPSv2-regression" failure. |
Where can I see that failure? Nevertheless, it's probably unrelated, since these are only additions. Could it be the same case as I have found here: #5579 (comment)?
|
That's from our internal Jenkins and not related to your changes. So just ignore for now. |
|
I've also added the server side PSK callbacks on top of this branch. May I add it to this pull request, or should a new one be opened once this one is merged? |
Yes please and add on top of this existing PR. Thank you! |
Plus fix location of the certificate files in the examples. Tested with both Ada examples: ``` obj/tls_server_main --psk obj/tls_client_main 127.0.0.1 --psk ```
|
Done. |
|
I am mostly an Ada connoisseur, but by just taking a look at the source code (without checking that the C signatures do indeed match those being imported), it looks fine :) I trust Manu, the compiler and the test to be good enough. Though I would recommend to also wait for at least someone with more experience to voice their point of view. Best regards, |
|
Retest this please. Build was aborted. |
I don't understand. The pull request says: "All checks have passed. 151 successful checks". |
|
@mgrojo you're good, the comment from David about restarting tests is directed at our internal testing system. Which it looks like it did re-run and now has the 151 successful checks. |
Description
This adds support in the Ada binding for
wolfSSL_set_psk_client_callback.Testing
Tested with:
wolfSSL/wolfssl-examples/psk/server-psk.cafter changing
DTLSv1_3_Client_MethodtoDTLSv1_2_Client_Methodto comply with the server example.Checklist