Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BN_CTX_get #8388

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Implement BN_CTX_get #8388

wants to merge 5 commits into from
+69 −53

Conversation

julek-wolfssl
Copy link
Member

No description provided.

@julek-wolfssl julek-wolfssl self-assigned this Jan 28, 2025
@julek-wolfssl julek-wolfssl mentioned this pull request Jan 28, 2025
Closed
4 tasks
@julek-wolfssl julek-wolfssl force-pushed the BN_CTX_get branch 2 times, most recently from fb0cb02 to 4c06c6a Compare January 28, 2025 13:34
SparkiDev
SparkiDev requested changes Jan 29, 2025
View reviewed changes
src/ssl_bn.c Show resolved Hide resolved
src/ssl_bn.c Outdated Show resolved Hide resolved
src/ssl_bn.c Outdated Show resolved Hide resolved
@julek-wolfssl
Copy link
Member Author

julek-wolfssl commented Jan 29, 2025 •
edited
Loading

Retest this please.

@SparkiDev SparkiDev assigned julek-wolfssl and unassigned SparkiDev Jan 29, 2025
SparkiDev
SparkiDev requested changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@SparkiDev SparkiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's happening with BN_CTX_start and BN_CTX_end?

src/ssl_bn.c Show resolved Hide resolved
@SparkiDev SparkiDev assigned julek-wolfssl and unassigned SparkiDev Feb 2, 2025
@julek-wolfssl
Copy link
Member Author

julek-wolfssl commented Feb 3, 2025 •
edited
Loading

We decided that BN_CTX_start and BN_CTX_end are not worth implementing in wolfSSL. They add unnecessary complexity and don't add any benefit in wolfSSL since we don't use BN_CTX internally.

@julek-wolfssl julek-wolfssl removed their assignment Feb 4, 2025
SparkiDev
SparkiDev requested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@SparkiDev SparkiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to have wolfSSL_BN_CTX_new().
Just don't allocate.

@julek-wolfssl
Copy link
Member Author

Added definitions for BN_CTX_new and BN_CTX_free when NO_WOLFSSL_BN_CTX is defined. Removed internal usage of wolfSSL_BN_CTX_new since it is not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SparkiDev SparkiDev SparkiDev requested changes

@JacobBarthelmeh JacobBarthelmeh JacobBarthelmeh left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@wolfSSL-Bot wolfSSL-Bot

@julek-wolfssl julek-wolfssl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julek-wolfssl @JacobBarthelmeh @SparkiDev @wolfSSL-Bot