Add support for parsing trusted PEM certs #8400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er/footer, needed for wolfProvider.
|
Retest this please. |
JacobBarthelmeh
requested changes
Jan 30, 2025
JacobBarthelmeh
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Test case looks good. One last item, is having new certificates be generated by the appropriate .sh script. In this case likely ./certs/test/gen-testcerts.sh. Not sure if ossl-trusted-cert.pem also needs added to the certs/test/include.am, but please try make distcheck to be sure.
|
Dang, I thought since I am only testing PEM to DER conversion it would be ok to even expire in the future, but you are right the diskcheck fails. I will add it to the generation script. |
JacobBarthelmeh
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parsing PEM certificates with begin trusted cert header/footer, needed for wolfProvider.
Fixes zd 18906