Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycloak/26.0.0 package update #30043

Closed
wants to merge 5 commits into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Oct 4, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. labels Oct 4, 2024
Copy link
Contributor Author

octo-sts bot commented Oct 4, 2024

Open AI suggestions to solve the build error:

The error log indicates that there is a non-readable POM file at the path `/home/build/adapters/oidc/js/pom.xml`, with the specific error being "No such file or directory." 

To resolve this issue, you should:

1. Verify that the file path `/home/build/adapters/oidc/js/pom.xml` is correct.
2. Check if the `pom.xml` file actually exists at the specified location.
3. If the file is located elsewhere, update the path in your build configuration to point to the correct location.
4. After making any necessary corrections, attempt to rebuild the project.

@debasishbsws debasishbsws self-assigned this Oct 4, 2024
@debasishbsws
Copy link
Member

keycloak/keycloak#32824 related upstream issue

@debasishbsws
Copy link
Member

The build will still fail until the bitnami container release keycloke 26. it is still in 25 https://github.com/bitnami/containers/tree/main/bitnami/keycloak

Copy link
Contributor Author

octo-sts bot commented Oct 4, 2024

Open AI suggestions to solve the build error:

The error log indicates a failure in executing the goal `com.github.eirslett:frontend-maven-plugin:1.15.0:pnpm` during the `pnpm-build` phase on the `keycloak-admin-ui` project. The task `pnpm build` failed with an exit value of 1. Here are some steps to troubleshoot:

1. Check the `pnpm` build logs for specific error messages.
2. Run `pnpm install` to ensure all dependencies are correctly installed.
3. Verify that the `pnpm` version is compatible with your project requirements.
4. Inspect the `package.json` file for any issues in the build scripts.
5. Try running `pnpm build` manually to identify and debug the problem.

Copy link
Contributor Author

octo-sts bot commented Oct 4, 2024

Open AI suggestions to solve the build error:

The error message indicates a failure in executing the `pnpm build` task within the `keycloak-admin-ui` project. The process exited with an error code 1. To resolve this issue, you can:

1. Check the `pnpm` build logs for specific errors.
2. Ensure all dependencies are correctly installed.
3. Verify that the `pnpm` version is compatible with your project.
4. Run `pnpm install` to update dependencies.
5. Clear the `node_modules` directory and `pnpm-lock.yaml` file, then attempt to rebuild.
6. Review the `package.json` file for any scripts that might be causing the failure.

@debasishbsws debasishbsws added the help wanted Extra attention is needed label Oct 4, 2024
@debasishbsws
Copy link
Member

The package build is failing because the bitnami container did not release for keycloke 26. it is still in 25 https://github.com/bitnami/containers/tree/main/bitnami/keycloak

But the error we are encountering is different for x86 and aarch64.
When I locally try to build locally with the old bitnami 25 configuration the x86_64 build is passing but it is not working for aarch_64.

The clear distinction we can make here by looking at the log difference, x86 is failing in the subpackage pipeline but in aarch64 it is failing in the main package pipeline

@debasishbsws debasishbsws removed their assignment Oct 7, 2024
@mamccorm
Copy link
Member

Hey @debasishbsws. I don't expect this will be all the changes necessary for Keycloak v26 (which is a significant update and a LOT of changes), but fixed up a couple of things in this commit: 09deaab

Copy link
Contributor Author

octo-sts bot commented Oct 10, 2024

Open AI suggestions to solve the build error:

The error log indicates a failure in executing the goal `com.github.eirslett:frontend-maven-plugin:1.15.0:pnpm` during the `pnpm-build` phase on the `keycloak-admin-ui` project. The task `'pnpm build'` failed with an exit value of 1. Here are some steps to troubleshoot:

1. Check the `pnpm` logs for detailed error messages.
2. Verify the dependencies listed in `package.json` for any issues.
3. Ensure that the `pnpm` version is compatible with your project requirements.
4. Run `pnpm install` to update and install all dependencies.
5. Check the build scripts for any syntax errors or misconfigurations.
6. Retry running `pnpm build` after addressing any identified issues.

@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed labels Oct 10, 2024
@mamccorm mamccorm force-pushed the wolfictl-dff84d46-48c6-4f41-89be-90de99ea15af branch from 09deaab to b815b4d Compare October 15, 2024 01:12
Copy link
Contributor Author

octo-sts bot commented Oct 15, 2024

Open AI suggestions to solve the build error:

The error log indicates a failure in executing the goal `com.github.eirslett:frontend-maven-plugin:1.15.0:pnpm` during the `pnpm-build` phase of the `keycloak-admin-ui` project. The specific error is that the task `'pnpm build'` failed with an exit value of 1. Here are some steps to address the issue:

1. Check the `pnpm` build logs for specific errors.
2. Ensure all dependencies are correctly installed.
3. Verify the `pnpm` version compatibility with the project.
4. Run `pnpm install` to update dependencies.
5. Check for any missing or misconfigured scripts in `package.json`.
6. Re-run the build command.

wolfi-bot and others added 4 commits October 15, 2024 12:05
…js/pom.xml (No such file or directory)

In this version 26.x upstream have Stop statically serving Keycloak JS from the Keycloak server and because of this we do not have a keycloak-js-adapter-jar child module to build upstream issue: keycloak/keycloak#32820

Signed-off-by: debasishbsws <[email protected]>
Signed-off-by: debasishbsws <[email protected]>
… which are both used by Keycloak v26

Signed-off-by: Mark McCormick <[email protected]>
@cpanato cpanato force-pushed the wolfictl-dff84d46-48c6-4f41-89be-90de99ea15af branch from b815b4d to f825843 Compare October 15, 2024 10:05
Copy link
Contributor Author

octo-sts bot commented Oct 15, 2024

Open AI suggestions to solve the build error:

The error log indicates a failure in executing the goal `com.github.eirslett:frontend-maven-plugin:1.15.0:pnpm` during the `pnpm-build` phase on the `keycloak-admin-ui` project. The task `'pnpm build'` failed with an exit value of 1. Here are some steps to troubleshoot:

1. Check the `pnpm` logs for more detailed error messages.
2. Ensure that all dependencies listed in `package.json` are correct and up-to-date.
3. Verify that the version of `pnpm` being used is compatible with your project.
4. Run `pnpm install` to update and install all necessary dependencies.
5. Look for any syntax errors or issues in your build scripts that might be causing the failure.

@cpanato
Copy link
Member

cpanato commented Oct 15, 2024

it is failing in arm in the part

 Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.0:pnpm (pnpm-build) on project keycloak-admin-ui: Failed to run task: 'pnpm build' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]

@debasishbsws
Copy link
Member

Guessing but it might be related to the same issue @kranurag7 is talking about in trino package-update PR
Anurag comment

given upstream is using frontend-maven-plugin to download node and npm, it won't work on aarch64 architecture because the plugin doesn't support aarch64 architecture.
It'll download node for x86 on arch which is incompatible. We need to use local nodejs and npm and from my previous work on hadoop, the local nodejs use is not officially allowed by the plugin. Somehow exec plugin needs to be tweaked to hack into node and allow local node usage.
upstream issues about the same: eirslett/frontend-maven-plugin#884 and eirslett/frontend-maven-plugin#1154

Copy link
Contributor Author

octo-sts bot commented Oct 15, 2024

Gen AI suggestions to solve the build error:

The error message indicates a failure in executing the `pnpm build` task within the `keycloak-admin-ui` project, specifically through the `frontend-maven-plugin`. The process exited with an error code 1. Here are some suggestions to address the issue:

1. Check the `pnpm` logs for more detailed error information.
2. Ensure that the dependencies listed in `package.json` are correct and up-to-date.
3. Verify that the version of `pnpm` being used is compatible with your project.
4. Run `pnpm install` to update and install all necessary dependencies.
5. Look for any syntax errors in your build scripts that might be causing the failure.
6. After addressing any issues, try running `pnpm build` again.

@cpanato
Copy link
Member

cpanato commented Oct 15, 2024

Guessing but it might be related to the same issue @kranurag7 is talking about in trino package-update PR Anurag comment

given upstream is using frontend-maven-plugin to download node and npm, it won't work on aarch64 architecture because the plugin doesn't support aarch64 architecture.
It'll download node for x86 on arch which is incompatible. We need to use local nodejs and npm and from my previous work on hadoop, the local nodejs use is not officially allowed by the plugin. Somehow exec plugin needs to be tweaked to hack into node and allow local node usage.
upstream issues about the same: eirslett/frontend-maven-plugin#884 and eirslett/frontend-maven-plugin#1154

that makes sense, what we should do here?

cc @TaylorBloom129 @mamccorm @xnox

@debasishbsws
Copy link
Member

It seems like for the hadoop-3.3 package we are skiping the UI build for aarch64

  - if: ${{build.arch}} == "aarch64"
    runs: |
      mvn -Pdist,native,src -DskipTests -Denforcer.skip=true -Dtar -Dmaven.javadoc.skip=true -Drequire.openssl -Drequire.fuse -Drequire.snappy clean package -e -X

  - if: ${{build.arch}} == "x86_64"
    runs: |
      mvn -Pdist,yarn-ui,native,src -DskipTests -Denforcer.skip=true -Dtar -Dmaven.javadoc.skip=true -Drequire.openssl -Drequire.fuse -Drequire.snappy clean package -e -X

Not sure if that is possible here or not. or if there is another approach.

Copy link
Contributor Author

octo-sts bot commented Oct 22, 2024

superseded by #31438

@octo-sts octo-sts bot deleted the wolfictl-dff84d46-48c6-4f41-89be-90de99ea15af branch October 22, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. help wanted Extra attention is needed interrupt manual/review-needed P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. request-version-update request for a newer version of a package squad:lifecycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants