gcc: remove some unneeded include-fixed headers #41033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
|
I see in Ubuntu gcc-14 they seem to remove the whole of include-fixed. Currently it only has pthread.h, so that would be fine. But I wouldn't want to do a blind |
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
sil2100
added
the
blocked
|
Let's not merge it before I run a test rebuild against it + glibc. |
octo-sts
bot
added
the
bincapz/pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the 2.41 glibc to FTBFS. Not sure why pthread.h fixincludes is still included - others seem to have been dropped. Anyway, right now it's so outdated re: glibc that it's causing issues. We certainly don't need it.