-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/35: replace setDescription with setDescriptionHtml #47
Conversation
QA Update ❌In the sandbox dashboard, the problem remains unresolved since the As discussed with @Sidsector9 this is the Square dashboard issue and we have requested the reopen the issue square/square-php-sdk#127 (comment) Video: Screenshare.-.2024-01-17.1_29_04.PM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is on hold until the issue is fixed from the square.
QA Update ✅I have checked this issue in the square/square-php-sdk#127 (comment) - Resolved Testing Environment
Steps to Test- As mentioned in the PR description. Screenshare.-.2024-01-23.8_33_35.PM.mp4Status update: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good to me 👍
✅ I added a description with a length of 5000 characters. The sync was successful in this branch, while it failed in trunk with a [VALUE_TOO_LONG] Field must not be greater than 4096 length
error message.
Thanks for the changes here, @Sidsector9 !
Regression / Smoke Test Report ✅Tested with Archive File created via "php woorelease.phar build repo_URL" (Composer version 2.5.5, npm version 8.19.4, node version 16.20.0) Testing Environment
Status- Working expected with Plugin Archive/Zip file same as fix specific branch. Next Step- Ready to Merge 🚀 Status update |
All Submissions:
Changes proposed in this Pull Request:
Closes #35 .
Steps to test the changes in this Pull Request:
Changelog entry