[BE] feat: deleted로 처리하던 로직을 isActive가 처리하도록 변경 #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenawee
approved these changes
Nov 14, 2023
| request.getoAuthProvider(), | ||
| request.getoAuthId() | ||
| ); | ||
| System.out.println("response.toString() = " + response.toString()); |
| this.isActivate = Boolean.FALSE; | ||
| } | ||
|
|
||
| public boolean isActive() { |
There was a problem hiding this comment.
isActive() 랑 isActivate 랑 통일하는게 좋지 않을까요?
gitchannn
added a commit
that referenced
this pull request
Nov 14, 2023
* feat: deleted로 처리하던 로직을 isActive가 처리하도록 변경 * refactor: 주석 해제 * fix: 조회 시에 activate true인 정책, 디자인만 조회하도록 변경 * refactor: 사용하지 않는 메서드 삭제 * help: 테스트 코드 에러 발생 * fix: Repository 테스트 에러 수정 * fix: ManagerCouponCommandServiceTest 깨지는거 수정 --------- Co-authored-by: yenawee <[email protected]>
gitchannn
added a commit
that referenced
this pull request
Nov 14, 2023
* feat: Coupon 테이블에 필드 추가 스크립트 * [BE] feat: deleted로 처리하던 로직을 isActive가 처리하도록 변경 (#936) * feat: deleted로 처리하던 로직을 isActive가 처리하도록 변경 * refactor: 주석 해제 * fix: 조회 시에 activate true인 정책, 디자인만 조회하도록 변경 * refactor: 사용하지 않는 메서드 삭제 * help: 테스트 코드 에러 발생 * fix: Repository 테스트 에러 수정 * fix: ManagerCouponCommandServiceTest 깨지는거 수정 --------- Co-authored-by: yenawee <[email protected]> * refactor: 출력 삭제 --------- Co-authored-by: yenawee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경사항
리뷰어에게...
관련 이슈
closes
체크리스트
reviewers설정label설정milestone설정