Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 날짜만 입력 시, 약속 추천 필터링 기능 제거 #400

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Largopie
Copy link
Contributor

관련 이슈

작업 내용

  • 약속 type이 DATETIME일 때만 필터링 기능을 렌더링 하도록 구현

특이 사항

날짜만 선택 기능으로 추천받을 때 500에러 발생 및 "길게 만나고 싶어요"라는 필터링 컨텍스트가 "시간"에만 필요한 기능이기 때문에 날짜만 선택 시 불필요한 필터링 기능이라 판단하고 제거

리뷰 요구사항 (선택)

@Largopie Largopie added 🐈 프론트엔드 프론트엔드 관련 이슈에요 :) ♻️ 리팩터링 코드를 깎아요 :) labels Oct 11, 2024
@Largopie Largopie added this to the 6차(최종) 데모데이 milestone Oct 11, 2024
@Largopie Largopie self-assigned this Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

Test Results

34 tests   34 ✅  24s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit c724c8d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Yoonkyoungme Yoonkyoungme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

낙타티티 고생했어요 굿~

Copy link
Contributor

@hwinkr hwinkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐪🐪🐪

@Largopie Largopie force-pushed the refactor/399-daysonly-remove-filter branch from 615fef6 to c724c8d Compare October 15, 2024 14:45
@Largopie Largopie merged commit fb88def into develop Oct 15, 2024
5 checks passed
@Largopie Largopie deleted the refactor/399-daysonly-remove-filter branch October 15, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ 리팩터링 코드를 깎아요 :) 🐈 프론트엔드 프론트엔드 관련 이슈에요 :)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FE] 날짜만 입력 시, 추천 필터링 기능을 제거해요 :)
3 participants