Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg-Mobile: Update gradle-node-plugin to use actively maintained fork #12923

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Gutenberg-Mobile: Update gradle-node-plugin to use actively maintained fork #12923

merged 1 commit into from
Sep 11, 2020

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Sep 10, 2020 •
edited
Loading

See WordPress/gutenberg#25208 for description and testing steps.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 10, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@mchowning mchowning added this to the 15.8 milestone Sep 10, 2020
@mchowning mchowning mentioned this pull request Sep 10, 2020
Merged
6 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 10, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@mchowning mchowning force-pushed the gutenberg/update_gradle-node-plugin branch from 4bf97c5 to 97bd7df Compare September 10, 2020 19:20
marecar3
marecar3 approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's working as expected!

@mchowning mchowning force-pushed the gutenberg/update_gradle-node-plugin branch from 97bd7df to 045f57d Compare September 11, 2020 13:59
@mchowning mchowning merged commit 315f18f into develop Sep 11, 2020
@mchowning mchowning deleted the gutenberg/update_gradle-node-plugin branch September 11, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
15.8
Development

Successfully merging this pull request may close these issues.
2 participants
@mchowning @marecar3