pulsarify all tools in the repo #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Thanks @martenson. Can you maybe come up with a small script to detect those tools. We probably want to add this to more tools.
in a version roughly from the same timeline
slesh is already part of the macro, not sure if this can faiil sometimes, but this commit should be correct always
|
@bgruening done |
martenson
changed the title
|
@martenson is there still an issue or do you have some idea why the tests are failing? |
|
@hechth I am not aware of any issue and I do not have access to this repo to troubleshoot tests. |
martenson
force-pushed
the
pulsar-readmsdata
branch
from
1955eec to
86d7eeb
Compare
|
Many tools' linting is failing because we are touching many tools now. Of course, it would be nice to fix those, but I can also understand if you just want to merge it. |
|
I took care to not break the linting with my modifications and I do not have the availability to fully re-lint all tools I am fixing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulsar needs to explicitly know about the files included in the command, this PR adds this information to all tools in the repo that are missing it (some already had it)
While having a look a this I also found some minor inconsistencies in requirements and syntax, check the later commits for details.
closes #279
FOR CONTRIBUTOR: