This repository has been archived by the owner on May 31, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
SEU line number commands GUI start (WIP) #13
Open
NathanielACollier
wants to merge
39
commits into
worksofliam:master
Choose a base branch
from
NathanielACollier:SEU-Line-Number-Commands-GUI-Start
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SEU line number commands GUI start (WIP) #13
NathanielACollier
wants to merge
39
commits into
worksofliam:master
from
NathanielACollier:SEU-Line-Number-Commands-GUI-Start
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from WorksOfBarry
Starting the initial code for textboxes where commands can be entered per line
Don't hide the textbox anymore
…w so that it's extremely fast
Got it to look right, but it's really slow and the textbox isn't clickable
It wasn't interactive because it wasn't added to the visual children
… numbers This resullted in major speed improvement. This will also allow keeping commands on non visible line numbers. Lots more options are availble with this type approach
NathanielACollier
added a commit
to NathanielACollier/AvalonEdit.Pieces.LineNumberMarginCommands
that referenced
this pull request
Dec 13, 2017
It's a really great examplle so need to make all those changes here that I made at this place: worksofliam/ILEditor#13
Updating Fork 2017-12-18
…line number margin width Trying to rely on wpf to do width as much as possible.
Using the SizeChanged event on listview to remeasure and give notice that width has changed, if it has...
This is to get it to display command textbox when mouse over line number textblock
…t happen inside commands
…hen hit enter Without that you'd have to type the command, loose focus, enter focus, then hit enter. d was being entered, then enter, but the command processing saw it as a blank command because the update source trigger was default of loose focus instead of propertychanged
Still have other problems though
…cases Split out Delete Line into it's own function because we will call that to implement d. We'll also end up making Insert line and calling it multiple times for i and i<n>
dd needs to take a first point and a last point and delete all lines in between
Updating from Liam
# Conflicts: # ILEditor/ILEditor.csproj
Added some notes about how the signaling is going to work using the model as a third party between the GUI of avalonedit, and the GUI of the command (Line number display)
…command to avalonedit and back
…mmand mode to start
…key goes to previous line number command
@NathanielACollier Any updates on this? :) |
I haven't had time to work on it. There are one or two issues that need to be fixed but it's pretty close except for commands being implemented. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it possible to enter commands per line number. This is a work in progress.
Here are the tasks needed that I can think of to merge: