Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved proto messages from package wfa.any_sketch to wfa.any_sketch.proto #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brianyi9
Copy link
Contributor

@brianyi9 brianyi9 commented Feb 7, 2024

Since we specify a java_package in the proto message, this suggests we may be able to change the package scoping while keeping everyone's java codebases intact, assuming the overrides work the way I think they do as described in https://protobuf.dev/programming-guides/proto3/#packages

Testing

Built with

bazelisk build --config=asan //src/test/...:*
bazelisk build --config=asan //src/main/...:*

Tested with

bazelisk test --config=asan //src/test/...:*

//src/test/cc/any_sketch:aggregators_test PASSED in 0.1s
//src/test/cc/any_sketch:any_sketch_test PASSED in 0.1s
//src/test/cc/any_sketch:distributions_test PASSED in 0.2s
//src/test/cc/any_sketch/crypto:secret_share_generator_test PASSED in 0.3s
//src/test/cc/any_sketch/crypto:shuffle_test PASSED in 0.3s
//src/test/cc/any_sketch/crypto:sketch_encrypter_adapter_test PASSED in 4.3s
//src/test/cc/any_sketch/crypto:sketch_encrypter_test PASSED in 3.0s
//src/test/cc/estimation:estimators_test PASSED in 0.3s
//src/test/cc/math:distributed_discrete_gaussian_noiser_test PASSED in 3.7s
//src/test/cc/math:distributed_geometric_noiser_test PASSED in 7.0s
//src/test/cc/math:noise_parameters_computation_test PASSED in 0.3s
//src/test/cc/math:open_ssl_uniform_random_generator_test PASSED in 0.2s

Executed 12 out of 12 tests: 12 tests pass.

@wfa-reviewable
Copy link

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants