Moved proto messages from package wfa.any_sketch to wfa.any_sketch.proto #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we specify a
java_package
in the proto message, this suggests we may be able to change the package scoping while keeping everyone's java codebases intact, assuming the overrides work the way I think they do as described in https://protobuf.dev/programming-guides/proto3/#packagesTesting
Built with
bazelisk build --config=asan //src/test/...:*
bazelisk build --config=asan //src/main/...:*
Tested with
bazelisk test --config=asan //src/test/...:*
//src/test/cc/any_sketch:aggregators_test PASSED in 0.1s
//src/test/cc/any_sketch:any_sketch_test PASSED in 0.1s
//src/test/cc/any_sketch:distributions_test PASSED in 0.2s
//src/test/cc/any_sketch/crypto:secret_share_generator_test PASSED in 0.3s
//src/test/cc/any_sketch/crypto:shuffle_test PASSED in 0.3s
//src/test/cc/any_sketch/crypto:sketch_encrypter_adapter_test PASSED in 4.3s
//src/test/cc/any_sketch/crypto:sketch_encrypter_test PASSED in 3.0s
//src/test/cc/estimation:estimators_test PASSED in 0.3s
//src/test/cc/math:distributed_discrete_gaussian_noiser_test PASSED in 3.7s
//src/test/cc/math:distributed_geometric_noiser_test PASSED in 7.0s
//src/test/cc/math:noise_parameters_computation_test PASSED in 0.3s
//src/test/cc/math:open_ssl_uniform_random_generator_test PASSED in 0.2s
Executed 12 out of 12 tests: 12 tests pass.