Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add matcher with zero args for comparing two protos #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stevenwarejones
Copy link
Contributor

@stevenwarejones stevenwarejones commented May 24, 2022

This change is Reviewable

@stevenwarejones stevenwarejones requested a review from SanjayVas May 24, 2022 19:49
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)


src/main/cc/common_cpp/testing/common_matchers.h line 26 at r1 (raw file):

// Returns true if two proto messages are equal, including the order of repeated
// fields.
MATCHER(EqualsProto, "") {

I'm not sure I understand the use case. The existing matcher appears to support test assertions of the form

EXPECT_THAT(actual, EqualsProto(expected))

What kind of assertion would this matcher be used for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants