-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Control plane integration test #1992
base: stevenwarejones_vid_labeling_tee_app
Are you sure you want to change the base?
Add Control plane integration test #1992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 21 files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @Marco-Premier, and @stevenwarejones)
a discussion (no related file):
Base this PR branch on the dependent PR branch and set the base on the PR in GitHub. See #1991 (review)
…nes_control_plane_integration_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 21 files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @Marco-Premier, and @SanjayVas)
a discussion (no related file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Base this PR branch on the dependent PR branch and set the base on the PR in GitHub. See #1991 (review)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 21 files reviewed, 2 unresolved discussions (waiting on @Marco-Premier, @SanjayVas, and @stevenwarejones)
src/test/kotlin/org/wfanet/measurement/securecomputation/ControlPlaneIntegrationTest.kt
line 101 at r4 (raw file):
val inMemoryStorageClient = InMemoryStorageClient() val subscribingStorageClient = GcsSubscribingStorageClient(inMemoryStorageClient) val vidLabelerApp =
Creating an "echo app" and using it here would be nice. Then you don't get caught up having to update this test as the VID Labeler App evolves, which surely it will. Plus an EchoApp would provide a nice example for people to work from.
Adds an In Process test
Depends on #1991