Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Control plane integration test #1992

Open
wants to merge 6 commits into
base: stevenwarejones_vid_labeling_tee_app
Choose a base branch
from

Conversation

stevenwarejones
Copy link
Collaborator

Adds an In Process test

  1. Set up data watcher
  2. Set up Vid Labeler
  3. Write input events to data watcher
  4. Data watcher matches events and calls control plane
  5. Vid Labeler finds and executes work from control plane
  6. Verify labeled data

Depends on #1991

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 21 files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @Marco-Premier, and @stevenwarejones)


a discussion (no related file):
Base this PR branch on the dependent PR branch and set the base on the PR in GitHub. See #1991 (review)

@stevenwarejones stevenwarejones changed the base branch from main to stevenwarejones_vid_labeling_tee_app January 7, 2025 18:49
Copy link
Collaborator Author

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 21 files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @Marco-Premier, and @SanjayVas)


a discussion (no related file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Base this PR branch on the dependent PR branch and set the base on the PR in GitHub. See #1991 (review)

Done.

Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 21 files reviewed, 2 unresolved discussions (waiting on @Marco-Premier, @SanjayVas, and @stevenwarejones)


src/test/kotlin/org/wfanet/measurement/securecomputation/ControlPlaneIntegrationTest.kt line 101 at r4 (raw file):

      val inMemoryStorageClient = InMemoryStorageClient()
      val subscribingStorageClient = GcsSubscribingStorageClient(inMemoryStorageClient)
      val vidLabelerApp =

Creating an "echo app" and using it here would be nice. Then you don't get caught up having to update this test as the VID Labeler App evolves, which surely it will. Plus an EchoApp would provide a nice example for people to work from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants