feat: World ID Section updates #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pdtfh
reviewed
Dec 7, 2023
pdtfh
reviewed
Dec 7, 2023
|
|
||
| ## Impact on Sign-In with World ID | ||
|
|
||
| When a user signs in with World ID, their Nullifier Hash is returned as the `sub` claim in the ID Token. Recall that the Nullifier Hash is the unique identifier of a user in the context of a specific action -- a different identity will return a different Nullifier Hash. |
There was a problem hiding this comment.
let's use as nullifier_hash everywhere?
There was a problem hiding this comment.
sub claim is required per OIDC specs, we can't rename it to something else
pdtfh
reviewed
Dec 7, 2023
pdtfh
reviewed
Dec 7, 2023
| @@ -41,25 +40,45 @@ const { address } = useAddress() // get the user's wallet address | |||
|
|
|||
| The World ID Router contract is what you should use to verify proofs. It is deployed on multiple chains, and you can find the addresses for each chain in our contracts [Address Book](/reference/address-book). | |||
|
|
|||
| ## `hashToField` helper function | |||
| ## `hashToField` Helper Function | |||
There was a problem hiding this comment.
@m1guelpf are we still exposing this from IDKit?
There was a problem hiding this comment.
hashToField is exported in @worldcoin/idkit-core/hashing
There was a problem hiding this comment.
for on-chain stuff, though, it should always be calculated in the smart contract itself rather than pre-computed off-chain and submitted in the TX
pdtfh
approved these changes
Dec 7, 2023
Co-authored-by: pdtfh <[email protected]>
0xPenryn
added a commit
that referenced
this pull request
Dec 13, 2023
* fix: small formatting * feat: device credential documentation (#240) * feat: reference section updates (#241) * chore: add world id bridge documentation (#230) Co-authored-by: pdtfh <[email protected]> * feat: explore apps (#246) * feat: World ID Section updates (#243) * feat: small on-chain docs improvements * feat: small fixes * feat: simplify dynamic actions * nit: phone -> device * nit: anchor link spacing * feat: World ID Reset documentation * Update src/pages/further-reading/world-id-reset.mdx Co-authored-by: pdtfh <[email protected]> * fix: time-bound sybil resistance --------- Co-authored-by: pdtfh <[email protected]> * feat: IDKit v1 migration guide (#244) Co-authored-by: pdtfh <[email protected]> * feat: naming updates (#248) Co-authored-by: pdtfh <[email protected]> * feat: remove /register endpoint (#249) * fix: update hero image on homepage * fix: migration PR feedback (#250) * fix: migration PR feedback * Update src/pages/id/world-id-lite.mdx Co-authored-by: pdtfh <[email protected]> * Update src/pages/id/world-id-lite.mdx Co-authored-by: pdtfh <[email protected]> * Update src/pages/id/world-id-lite.mdx Co-authored-by: pdtfh <[email protected]> * fix: address feedback --------- Co-authored-by: pdtfh <[email protected]> * nit: tiny prop name error * fix: remove readme sync (#251) * fix: broken links * feat: errors reference page (#247) * feat: errors reference page * fix: nav name * fix: remove wallet bridge section * fix: split table by service/package * feat: final v1 updates (#252) * fix: verification_level, World ID Device, OIDC claim * feat: idkit v1.1, update incognito actions section of try it page * feat: verification levels page merged "World ID Device" and "Proof of Personhood" pages to create this * fix: remove theme param and add to migration guide * feat: user-agent header requirement * fix: try page theme * fix: closing tag * feat: verify with world id page * feat: errors reorg * fix: feedback * bump: IDKit v1.1.1 * fix: apps link --------- Co-authored-by: pdtfh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes documentation of World ID Reset, its impacts, and associated suggestions for integrations