hum: fix negative missing observation count #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingyuyap
force-pushed
the
bing/hum-negative-obs-count
branch
2 times, most recently
from
4c0a8da to
ee51cde
Compare
bruce-riley
reviewed
Sep 4, 2024
panoel
reviewed
Sep 4, 2024
panoel
previously approved these changes
Sep 4, 2024
bruce-riley
reviewed
Sep 4, 2024
bingyuyap
force-pushed
the
bing/hum-negative-obs-count
branch
from
d522ad1 to
58a2a33
Compare
bruce-riley
previously approved these changes
Sep 4, 2024
hum: improve decrement missing obs hum: cleanup Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
hum: fix tests hum: add tests for flushing hum: clean up hum: final clean up Signed-off-by: bingyuyap <[email protected]>
Signed-off-by: bingyuyap <[email protected]>
bingyuyap
force-pushed
the
bing/hum-negative-obs-count
branch
from
212f1d3 to
e20d2f1
Compare
bruce-riley
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes negative observation count in the historical uptime monitor. It seems like RockawayX is sending duplicated observations really quickly such that the bigtable checks are not catching them. Additional dedup logic is needed when calculating missing observations.
This PR also:
for further debugging for the dropped observations bug