Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node/Solana: Shim support in testnet #4241

Conversation

bruce-riley
Copy link
Contributor

@bruce-riley bruce-riley commented Jan 24, 2025

This PR adds support for the Solana shim contract in testnet (but not mainnet).

To use this feature, set the following parameters:

--solanaRPC YOUR_SOLANA_RPC
--solanaContract 3u8hJUVTA4jH1wYAyUur7FFZVQ8H635K3tSHHF4ssjQ5 
--solanaShimContract EtZMZM22ViKMo4r5y4Anovs3wKQ2owUmDpjygnMMcdEX

Don't be alarmed by the size of this PR. A thousand lines of it are tests, and most of that is JSON encoded transactions.

evan-gray
evan-gray previously approved these changes Jan 24, 2025
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that these changes match what I previously reviewed in wormholelabs-xyz#11 with the addition of disabling mainnet support.

@bruce-riley bruce-riley marked this pull request as ready for review January 27, 2025 14:08
@bruce-riley bruce-riley requested a review from panoel as a code owner January 27, 2025 14:08
panoel
panoel previously approved these changes Jan 27, 2025
@bruce-riley bruce-riley dismissed stale reviews from panoel and evan-gray via e716e53 January 27, 2025 15:53
@bruce-riley bruce-riley force-pushed the node/solana_shim_support_in_testnet branch from e716e53 to b2c9ac6 Compare January 27, 2025 15:53
@bruce-riley bruce-riley merged commit c8b4aa5 into wormhole-foundation:main Jan 27, 2025
29 checks passed
@bruce-riley bruce-riley deleted the node/solana_shim_support_in_testnet branch January 27, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants