Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make translatable the due date output #695

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Make translatable the due date output #695

merged 1 commit into from
Jan 24, 2024

Conversation

YordanSoares
Copy link
Contributor

Closes: #694

@YordanSoares YordanSoares self-assigned this Jan 23, 2024
@dwalkerpriv
Copy link
Contributor

Works on my end. the only issue is that the month starts with a common letter

Screenshot 2024-01-23 155330

@YordanSoares
Copy link
Contributor Author

@dwalkerpriv it depends on the user locale. For instance, this is the output for German (de_DE):

image

@dwalkerpriv
Copy link
Contributor

@YordanSoares i see 👍

alexmigf
alexmigf approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@alexmigf alexmigf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexmigf alexmigf merged commit 37c7d60 into main Jan 24, 2024
5 checks passed
@alexmigf alexmigf deleted the issue-694-due-date-i18n-issue branch January 24, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmigf alexmigf alexmigf approved these changes

@dwalkerpriv dwalkerpriv dwalkerpriv approved these changes

Assignees

@YordanSoares YordanSoares

Labels
bug i18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix i18n issue with the due date output
3 participants
@YordanSoares @dwalkerpriv @alexmigf