Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: renumbering documents not working #705

Merged
merged 15 commits into from
Feb 9, 2024
Merged

Fix: renumbering documents not working #705

merged 15 commits into from
Feb 9, 2024

Conversation

alexmigf
Copy link
Member

closes #704

@alexmigf alexmigf mentioned this pull request Feb 5, 2024
Closed
MohamadNateqi
MohamadNateqi requested changes Feb 5, 2024
View reviewed changes
woocommerce-pdf-invoices-packingslips.php Outdated Show resolved Hide resolved
woocommerce-pdf-invoices-packingslips.php Outdated Show resolved Hide resolved
MohamadNateqi
MohamadNateqi requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@MohamadNateqi MohamadNateqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed:
https://github.com/wpovernight/woocommerce-pdf-invoices-packing-slips/pull/705/files#diff-19a452d809d082bbe584c079e40cf32b00abd705fa2e4e60c6ec4f4cf6e1efd6L21-L25

includes/documents/class-wcpdf-invoice.php Outdated Show resolved Hide resolved
includes/settings/class-wcpdf-settings-debug.php Outdated Show resolved Hide resolved
includes/settings/class-wcpdf-settings-debug.php Outdated Show resolved Hide resolved
includes/documents/abstract-wcpdf-order-document.php Outdated Show resolved Hide resolved
MohamadNateqi
MohamadNateqi approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@MohamadNateqi MohamadNateqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@alexmigf
Copy link
Member Author

alexmigf commented Feb 7, 2024

@dwalkerpriv @YordanSoares @dpeyou can you test if the Invoice numbers are working correctly?

YordanSoares
YordanSoares approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@YordanSoares YordanSoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with legacy and HPOS order data storage.

dwalkerpriv
dwalkerpriv approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@dwalkerpriv dwalkerpriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting numbers, renumbering, recreating and renumbering documents after deleting them works great for all documents 👍

dpeyou
dpeyou approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@dpeyou dpeyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears ready to be released into the wild 👍

@alexmigf alexmigf merged commit 4532722 into main Feb 9, 2024
5 checks passed
@alexmigf alexmigf deleted the 704-fix-renumbering-documents-issue branch February 9, 2024 08:28
@dpeyou dpeyou mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YordanSoares YordanSoares YordanSoares approved these changes

@dwalkerpriv dwalkerpriv dwalkerpriv approved these changes

@dpeyou dpeyou dpeyou approved these changes

@MohamadNateqi MohamadNateqi MohamadNateqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renumbering documents tool not working
5 participants
@alexmigf @YordanSoares @dwalkerpriv @dpeyou @MohamadNateqi