Merge pull request #200 from sadilchamishka/fix-memory-leak-callchoreo

Fix memory leak of the callChoreo access token request helper function
wso2-extensions · Jan 16, 2025 · f3d56f9 · f3d56f9
2 parents 11f75ce + df73476
commit f3d56f9
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/...va/org/wso2/carbon/identity/conditional/auth/functions/choreo/CallChoreoFunctionImpl.java b/...va/org/wso2/carbon/identity/conditional/auth/functions/choreo/CallChoreoFunctionImpl.java
@@ -343,7 +343,8 @@ public void completed(HttpResponse httpResponse) {
 
             boolean isFailure = false;
             try {
-                LOG.debug("Access token response received.");
+                LOG.info("Access token response received. Session data key: " +
+                        authenticationContext.getContextIdentifier());
                 int responseCode = httpResponse.getStatusLine().getStatusCode();
                 if (responseCode == HTTP_STATUS_OK) {
                     Type responseBodyType = new TypeToken<Map<String, String>>() { }.getType();
@@ -372,6 +373,8 @@ public void completed(HttpResponse httpResponse) {
                 LOG.error("Error occurred while handling the token response from Choreo. Session data key: " +
                         authenticationContext.getContextIdentifier(), e);
                 isFailure = true;
+            } finally {
+                EntityUtils.consumeQuietly(httpResponse.getEntity());
             }
 
             if (isFailure) {