-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle complex JSON payloads for Call Choreo function and call Analytics function #187
Conversation
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10110536222
...org/wso2/carbon/identity/conditional/auth/functions/analytics/CallAnalyticsFunctionImpl.java
Outdated
Show resolved
Hide resolved
...org/wso2/carbon/identity/conditional/auth/functions/analytics/CallAnalyticsFunctionImpl.java
Outdated
Show resolved
Hide resolved
...org/wso2/carbon/identity/conditional/auth/functions/analytics/CallAnalyticsFunctionImpl.java
Outdated
Show resolved
Hide resolved
...org/wso2/carbon/identity/conditional/auth/functions/analytics/CallAnalyticsFunctionImpl.java
Outdated
Show resolved
Hide resolved
...org/wso2/carbon/identity/conditional/auth/functions/analytics/CallAnalyticsFunctionImpl.java
Outdated
Show resolved
Hide resolved
lets add the necessary unit tests for this scenario along with this PR |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
* Add unit tests for non-serialized JSON payload * Add unit tests for JSON response
...sources/org/wso2/carbon/identity/conditional/auth/functions/analytics/analytics-payload.json
Outdated
Show resolved
Hide resolved
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10496986688
...est/resources/org/wso2/carbon/identity/conditional/auth/functions/choreo/choreo-payload.json
Show resolved
Hide resolved
...est/resources/org/wso2/carbon/identity/conditional/auth/functions/choreo/payload-test-sp.xml
Outdated
Show resolved
Hide resolved
.../carbon/identity/conditional/auth/functions/test/utils/sequence/JsSequenceHandlerRunner.java
Outdated
Show resolved
Hide resolved
.../carbon/identity/conditional/auth/functions/test/utils/sequence/JsSequenceHandlerRunner.java
Outdated
Show resolved
Hide resolved
...st/resources/org/wso2/carbon/identity/conditional/auth/functions/http/http-get-response.json
Outdated
Show resolved
Hide resolved
...t/java/org/wso2/carbon/identity/conditional/auth/functions/http/HTTPGetFunctionImplTest.java
Outdated
Show resolved
Hide resolved
...t/java/org/wso2/carbon/identity/conditional/auth/functions/http/HTTPGetFunctionImplTest.java
Outdated
Show resolved
Hide resolved
.../java/org/wso2/carbon/identity/conditional/auth/functions/http/HTTPPostFunctionImplTest.java
Outdated
Show resolved
Hide resolved
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10576680519
$Subject
Depends on