Resolved NPE in self-registering a user to an invalid user realm through API #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadilchamishka
requested changes
Jul 11, 2024
...so2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/util/Utils.java
Outdated
Show resolved
Hide resolved
...so2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/util/Utils.java
Outdated
Show resolved
Hide resolved
|
|
sadilchamishka
previously approved these changes
Jul 12, 2024
ImalshaG
reviewed
Jul 15, 2024
...so2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/util/Utils.java
Outdated
Show resolved
Hide resolved
ImalshaG
reviewed
Jul 15, 2024
...so2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/util/Utils.java
Show resolved
Hide resolved
ImalshaG
reviewed
Jul 15, 2024
...so2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/util/Utils.java
Outdated
Show resolved
Hide resolved
ImalshaG
reviewed
Jul 15, 2024
...carbon.identity.recovery/src/test/java/org/wso2/carbon/identity/recovery/util/UtilsTest.java
Outdated
Show resolved
Hide resolved
| UserStoreManager secondaryUserStoreManager = | ||
| ((org.wso2.carbon.user.core.UserStoreManager) userStoreManager).getSecondaryUserStoreManager( | ||
| user.getUserStoreDomain()); | ||
| if (secondaryUserStoreManager != null) { |
There was a problem hiding this comment.
Let's return exception if null first and return the result at the end.
There was a problem hiding this comment.
Returning exception at the end of the logic given a wrong expression.
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10035889426
sadilchamishka
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the getRealmConfiguration method in 'org/wso2/carbon/identity/recovery/util/Utils.java' to handle NullPointerException when retrieving the RealmConfiguration based on the user's domain.
Proposed changes in this pull request
Related Issue
Cause of Issue
The existing implementation did not handle the case where getSecondaryUserStoreManager returned null when an invalid user store domain is provided, which caused an unexpected NullPointerException during runtime.