Add SMS password recovery event compatibility with SMSNotificationHandler #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
RushanNanayakkara
force-pushed
the
fix_sms_not_not_sent
branch
from
132f7ea to
cf5bf67
Compare
|
PR builder started |
| * @return email address of the user. | ||
| * @throws IdentityRecoveryServerException | ||
| */ | ||
| private String getEmail(User user) throws IdentityRecoveryServerException { |
There was a problem hiding this comment.
getEmail function is moved to the Util class as getUserClaim function to use with both email and mobile claims.
|
PR builder completed |
jenkins-is-staging
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9940156944
sadilchamishka
approved these changes
Jul 15, 2024
This was referenced Jul 16, 2024
Add otpTokenString parameter to SMSNotificationHandler
wso2-extensions/identity-local-auth-smsotp#23
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Related issue