-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support usernames recovery when claims are not unique #859
Support usernames recovery when claims are not unique #859
Conversation
...java/org/wso2/carbon/identity/recovery/internal/service/impl/UserAccountRecoveryManager.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #859 +/- ##
=========================================
Coverage ? 24.21%
Complexity ? 996
=========================================
Files ? 267
Lines ? 15478
Branches ? 2094
=========================================
Hits ? 3748
Misses ? 11256
Partials ? 474 ☔ View full report in Codecov by Sentry. |
...carbon/identity/recovery/internal/service/impl/username/UsernameRecoveryManagerImplTest.java
Outdated
Show resolved
Hide resolved
The changed functionality has been tested with WSO2IS-7.1.0-m2. Both flows (with and without the configuration) are working as expected. For unique users, the functionality remains the same, and recovery emails are sent to their registered addresses. When the configuration is enabled, the system also sends multiple recovery notifications for non-unique users. Hence the behaviour matching the expected functionality. |
Proposed changes in this pull request
deployment.toml
When this configuration is enabled, the system will send multiple recovery notifications with all usernames associated with the identified users.
Follow up actions
Related Git Issue
Related PRs
Checklist
General
Functionality
Code
Tests
Security