-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add governance config to enable/disable multiple emails and mobiles per user feature #866
Add governance config to enable/disable multiple emails and mobiles per user feature #866
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #866 +/- ##
============================================
+ Coverage 36.04% 36.12% +0.08%
- Complexity 1450 1451 +1
============================================
Files 267 267
Lines 15790 15811 +21
Branches 2182 2184 +2
============================================
+ Hits 5691 5712 +21
+ Misses 9384 9383 -1
- Partials 715 716 +1 ☔ View full report in Codecov by Sentry. |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11403151366
} catch (IdentityEventException e) { | ||
log.error("Error while getting connector configurations support multi emails and mobile numbers per" + | ||
" user.", e); | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the default value. If it is true, fine to return true.
The decision has been revised to exclude the governance configuration for this feature. |
Proposed changes in this pull request
Introduced a governance configuration to enable or disable the "multiple emails and mobile numbers per user" feature.
This feature is not fully onboarded yet. The original plan was to implement an identity configuration that would apply server-wide and enable this functionality by default. However, the new attributes required for this feature are not supported by default in LDAP user stores. As a result, enabling it globally is not feasible at this time. By providing a governance configuration, administrators can choose to enable this feature if desired. For LDAP user stores, the administrator must manually configure the necessary attributes in the LDAP settings to support multiple emails and mobile numbers per user.
Related Issues
Related PRs