Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] Add role based scope validation config enabled check #2305

Conversation

mpmadhavig
Copy link
Contributor

@mpmadhavig mpmadhavig commented Dec 14, 2023

Proposed changes in this pull request

  • By default the role based global scope validation is enable which result in unnecessary scope validation for each and every authorize. In this effort we introduce the RoleBasedScopeValidation.Enabled config to enable this.

Related Issues:

@mpmadhavig mpmadhavig force-pushed the skip-role-based-scope-validation-by-default branch from 19a94ae to aa132a2 Compare December 14, 2023 07:38
@mpmadhavig mpmadhavig changed the title Add role based scope validation config enabled check [perf] Add role based scope validation config enabled check Dec 14, 2023
@mpmadhavig mpmadhavig force-pushed the skip-role-based-scope-validation-by-default branch 3 times, most recently from 3bd4599 to 1f5d05d Compare December 14, 2023 08:06
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7207274822

SujanSanjula96
SujanSanjula96 previously approved these changes Dec 14, 2023
@SujanSanjula96 SujanSanjula96 dismissed their stale review December 14, 2023 10:11

additional improvement

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7207274822
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7207274822

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2023

CLA assistant check
All committers have signed the CLA.

@mpmadhavig mpmadhavig force-pushed the skip-role-based-scope-validation-by-default branch from 7e35cc3 to e941607 Compare December 15, 2023 10:44
…o2/carbon/identity/oauth/config/OAuthServerConfiguration.java

Co-authored-by: Sujan Sanjula <[email protected]>
@mpmadhavig mpmadhavig merged commit 8b637a1 into wso2-extensions:master Dec 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants